[SYCL] group operations update to use size() #7589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, this is a little scary! I guess the byte size is always bigger than the size, so the loop is always big enough. It might write some extra memory, but nothing in the test checks against that... Good catch, @cperkinsintel. I agree with Sergey's suggestion to use the non-deprecated functions, but otherwise have nothing to add. |
cperkinsintel
changed the title
sergey-semenov
approved these changes
Dec 2, 2022
cperkinsintel
added a commit
to cperkinsintel/llvm-test-suite
that referenced
this pull request
Jan 2, 2023
…ction using sycl::vec<float>. Is sensitive to byte size vs. vector size fix in SYCL headers.
againull
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Jan 4, 2023
…1480) Test to follow up on recent fix intel/llvm#7589. Test performs a reduction using sycl::vec<float>. Is sensitive to byte size vs. vector size fix in SYCL headers.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ntel/llvm-test-suite#1480) Test to follow up on recent fix intel#7589. Test performs a reduction using sycl::vec<float>. Is sensitive to byte size vs. vector size fix in SYCL headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_size()returns byte size. it issize()that is wanted in these group operations.