Skip to content

[SYCL][Level Zero] Don't use ZE_MEMORY_ADVICE_SET_READ_MOSTLY for read-only USM #7601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2022
Merged

[SYCL][Level Zero] Don't use ZE_MEMORY_ADVICE_SET_READ_MOSTLY for read-only USM #7601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c3a666
[SYCL][Level Zero] Don't use ZE_MEMORY_ADVICE_SET_READ_MOSTLY for rea…
aelovikov-intel Nov 30, 2022
7e67fe4
Adjust comments - read-only guarantee doesn't have L0 API yet.
aelovikov-intel Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions sycl/plugins/level_zero/pi_level_zero.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7942,9 +7942,8 @@ static pi_result USMSharedAllocImpl(void **ResultPtr, pi_context Context,
// with the same command list handle.
std::scoped_lock<pi_mutex> Lock(Context->ImmediateCommandListMutex);

ZE_CALL(zeCommandListAppendMemAdvise,
(Context->ZeCommandListInit, Device->ZeDevice, *ResultPtr, Size,
ZE_MEMORY_ADVICE_SET_READ_MOSTLY));
// TODO: Underlying Level Zero runtime doesn't have a way to communicate
// read-only property yet.

ZE_CALL(zeCommandListAppendMemAdvise,
(Context->ZeCommandListInit, Device->ZeDevice, *ResultPtr, Size,
Expand Down