-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Update support of online_compiler; advance default GPU device #7674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Update support of online_compiler; advance default GPU device #7674
Conversation
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
gpu_gen12 = 5 | ||
gpu_gen12 = 5, | ||
gpu_tgl = gpu_gen12, | ||
gpu_tgllp = gpu_gen12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this enum should eventually be deprecated and replaced with https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_intel_device_architecture.asciidoc#new-enumeration-of-architectures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That enum is better, but IMO still not perfect solution because
a) that enum may need special conversion to string, e.g. intel_gpu_icllp -> "icllp"; intel_gpu_acm_g12 -> "something-else'.
b) ocloc allows specifying not only 1 device, but a set of them using comma, e.g. "-device icllp,tgllp", and also it allows range of devices, e.g. "-device icllp:" which means something like icllp and newer.
Taking (a) and (b) into account, wouln't it be convenient to let user have that great flexibility provided by 'oclocl'? If Yes, the best ways is to let user specify the 'device_option' or 'device_filter' of std::string type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what problem are you trying to solve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local goal in this PR: online_compiler became unusable after recent changes in GPU RT on Gen12 Windows - it stopped supporting "-device skl", cfl, etc. This PR changes the default from "skl" and adds mapping from enum gpu::gpu_gen12 to string "tgllp".
Bigger goal for future PRs should be (IMO): to allow users to compile for target device or group of devices they need and not be limited with some pre-defined enum (either the one used today, or this one https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_intel_device_architecture.asciidoc#new-enumeration-of-architectures)
The fails are known and unrelated to this PR: #7634 |
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Signed-off-by: Vyacheslav N Klochkov [email protected]