[NFC][SYCL] Use C++17 nested namespaces #7692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change was done semi-automtically via clang-tidy with subsequent manual review to revert incorrect changes followed by clang-format run to update the comments on the namespace closing bracket.
aelovikov-intel
requested review from
rolandschulz,
kbobrovs and
a team
as code owners
aelovikov-intel
commented
Dec 7, 2022
bader
approved these changes
Dec 7, 2022
Comment on lines
+44
to
+52
| namespace property ::queue { | ||
| namespace __SYCL2020_DEPRECATED( | ||
| "use 'sycl::ext::oneapi::cuda::property::queue' instead") cuda { | ||
| class use_default_stream | ||
| : public ::sycl::ext::oneapi::cuda::property::queue::use_default_stream {}; | ||
| // clang-format off | ||
| } // namespace cuda | ||
| // clang-format on | ||
| } // namespace queue | ||
| } // namespace property | ||
| } // namespace property::queue |
There was a problem hiding this comment.
Probably we should move this before namespace ext::oneapi declarations.
There was a problem hiding this comment.
I'd rather not do it here.
sycl/include/sycl/ext/intel/math.hpp
Outdated
| namespace ext { | ||
| namespace intel { | ||
| namespace math { | ||
| namespace ext::intel::math { | ||
|
|
||
| #if __cplusplus >= 201703L |
There was a problem hiding this comment.
Do we still intended to support compatibility with C++14 mode? I see that some C++17 features are being used unconditionally.
againull
approved these changes
Dec 8, 2022
|
@rolandschulz @kbobrovs , please review this trivial change. |
|
@intel/llvm-gatekeepers , PR is ready. |
keryell
reviewed
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change was done semi-automtically via clang-tidy with subsequent manual review to revert incorrect changes followed by clang-format run to update the comments on the namespace closing bracket.