Skip to content

[SYCL][CUDA] Fix a test which assumed build on Linux machines. #7734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

mmoadeli
Copy link
Contributor

Fix a test which assumed build on Linux machines.

@mmoadeli mmoadeli requested a review from a team as a code owner December 12, 2022 11:05
@mmoadeli
Copy link
Contributor Author

mmoadeli commented Dec 12, 2022

@pvchupin,
would you (or any one else) please be able to run CI on a Windows machine for this PR.

@pvchupin
Copy link
Contributor

@mmoadeli, have you run tests locally on windows machine?

@mmoadeli
Copy link
Contributor Author

This PR fixes the issue seen in
#7348

Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvchupin pvchupin merged commit 4c22e7b into intel:sycl Dec 12, 2022
@pvchupin
Copy link
Contributor

@mmoadeli, there are still problems. Can you take a look?
https://github.com/intel/llvm/actions/runs/3678070586/jobs/6220866632

@mmoadeli
Copy link
Contributor Author

mmoadeli commented Dec 12, 2022

@mmoadeli, there are still problems. Can you take a look? https://github.com/intel/llvm/actions/runs/3678070586/jobs/6220866632

@pvchupin Sorry, my impression was that it would be possible to run this PR on Windows CI machine without the need for merge.
The tested PR is #7753

@pvchupin
Copy link
Contributor

@mmoadeli, windows testing is in post-commit, if you are checking change locally usually it's enough, otherwise (if you don't have a local windows box) there is a trick is to add a dummy change to post-commit job so that post-commit is triggered in pre-commit, then revert it back before merge.

@mmoadeli mmoadeli deleted the fix-oneapi-gpu-lit branch July 7, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants