[SYCL] Fix ext::oneapi::experimental::joint_reduce #7781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes ext::oneapi::experimental::joint_reduce, it misses group_broadcast for partial result, reproduced on the specific test case Test: TBA to llvm-test-suite
dm-vodopyanov
added a commit
to dm-vodopyanov/llvm-test-suite
that referenced
this pull request
Dec 14, 2022
This patch add new test which caught missing syncronization issue. Impl: intel/llvm#7781
|
/verify with intel/llvm-test-suite#1452 |
|
/verify with intel/llvm-test-suite#1452 |
romanovvlad
reviewed
Dec 19, 2022
sycl/include/sycl/ext/oneapi/experimental/user_defined_reductions.hpp
Outdated
Show resolved
Hide resolved
|
/verify with intel/llvm-test-suite#1452 |
romanovvlad
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes ext::oneapi::experimental::joint_reduce, it missed
the case when WG size is bigger than size of input data.
Test: intel/llvm-test-suite#1452