[SYCL] Fix scheduler unit test: EnqueueNoMemObjDoubleKernelDepHostBlo… #7793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cked Signed-off-by: Tikhomirova, Kseniya <[email protected]>
againull
reviewed
Dec 16, 2022
Comment on lines
+230
to
+231
| detail::Command *Cmd1 = | ||
| AddTaskCG(TestCGType::HOST_TASK, Events, &CustomHostLambda); |
There was a problem hiding this comment.
Do I get it right that the main purpose of CustomHostLambda is to prevent tests from running in parallel?
There was a problem hiding this comment.
no, it is used to block host task from its completion.
There was a problem hiding this comment.
host task should block dependent kernels till its completion, I need to hold host task to check it. I do it with mutex I lock before host task submission and unlock after some intermediate checks. Than I wait till host task completion and check that kernels were enqueued.
againull
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cked
Signed-off-by: Tikhomirova, Kseniya [email protected]