[SYCL] Use decorated pointer in device_global #7796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
device_global without device_image_scope currently use an undecorated pointer for its underlying type, but we know that the pointer will be to the global memory space. This commit changes the underlying member to be a decorated pointer and change the get_multi_ptr member function to create the multi_ptr directly from the decorated pointer instead of performing unnecessary address space casts. Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
dm-vodopyanov
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device_global without device_image_scope currently use an undecorated pointer for its underlying type, but we know that the pointer will be to the global memory space. This commit changes the underlying member for device_global with device_image_scope to be a decorated pointer and changes the get_multi_ptr member function to create the multi_ptr directly from the decorated pointer instead of performing unnecessary address space casts.