[SYCL] Add check-sycl-dumps target for dumps-only testing #7830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new check-sycl-dumps target. This intends to only run SYCL runtime library related dump tests and will therefore only build llvm-readobj, the SYCL libraries (including the enabled plugins), and any dependencies required by LIT. Purpose of this is to allow for faster ABI dump checks on multiple systems. Signed-off-by: Larsen, Steffen <[email protected]>
romanovvlad
approved these changes
Dec 19, 2022
sycl/cmake/modules/AddSYCL.cmake
Outdated
| @@ -10,7 +10,7 @@ function(add_sycl_library LIB_NAME TYPE) | |||
| target_link_libraries(${LIB_NAME} PRIVATE ${ARG_LIBRARIES}) | |||
|
|
|||
| if (ARG_TOOLCHAIN) | |||
There was a problem hiding this comment.
Probably we need to remove the option then.
There was a problem hiding this comment.
Doesn't look like we were using it anyway, so it has been removed!
Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new check-sycl-dumps target. This intends to only run SYCL runtime library related dump tests and will therefore only build llvm-readobj, the SYCL libraries (including the enabled plugins), and any dependencies required by LIT. Purpose of this is to allow for faster ABI dump checks on multiple systems.