Skip to content

[SYCL] Uninitialized value used with IntelNamedSubGroupSize #7918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2023
Merged

[SYCL] Uninitialized value used with IntelNamedSubGroupSize #7918

merged 1 commit into from
Jan 4, 2023

Conversation

premanandrao
Copy link
Contributor

A release compiler build with the memory sanitizer discovered the use of an uninitialized value in SemaDeclAttr.cpp while running the test SemaSYCL/sub-group-size.cpp. It was caused by not returning early after diagnosing invalid attribute values.

@premanandrao
[SYCL] Uninitialized value used with IntelNamedSubGroupSize
e04e4a5 
A release compiler build with the memory sanitizer discovered
the use of an uninitialized value in SemaDeclAttr.cpp while running
the test SemaSYCL/sub-group-size.cpp.  It was caused by not
returning early after diagnosing invalid attribute values.
@premanandrao premanandrao requested a review from a team as a code owner January 4, 2023 19:10
@premanandrao
Copy link
Contributor Author

This is not quite NFC, but I find it hard to write a test case for this. Please let me know if there are any lit test techniques to trigger a failure.

@smanna12
Copy link
Contributor

smanna12 commented Jan 4, 2023

This is not quite NFC, but I find it hard to write a test case for this. Please let me know if there are any lit test techniques to trigger a failure.

I am not sure either about how to test this.

@premanandrao premanandrao temporarily deployed to aws January 4, 2023 19:53 — with GitHub Actions Inactive
@premanandrao premanandrao temporarily deployed to aws January 4, 2023 20:23 — with GitHub Actions Inactive
@bader
Copy link
Contributor

bader commented Jan 4, 2023

This is not quite NFC, but I find it hard to write a test case for this. Please let me know if there are any lit test techniques to trigger a failure.

Probably we should build "release compiler with the memory sanitizer" and run as much tests as we can.

@againull
Copy link
Contributor

againull commented Jan 4, 2023

HIP failure SYCL :: Regression/half_operators.cpp is known and unrelated.

@againull againull merged commit 81ca1dc into sycl Jan 4, 2023
@premanandrao
Copy link
Contributor Author

Probably we should build "release compiler with the memory sanitizer" and run as much tests as we can.

Especially when it is finding bugs that have been in the codebase for many, many months.

premanandrao added a commit that referenced this pull request Jan 5, 2023
@premanandrao
[SYCL] Test for PR #7918 - invalid value in named_sub_group_size
9efc407 
When PR #7918 was submitted, a test wasn't added along with it.
@premanandrao premanandrao mentioned this pull request Jan 5, 2023
Merged
bader pushed a commit that referenced this pull request Jan 5, 2023
@premanandrao
[SYCL] Test for PR #7918 - invalid value in named_sub_group_size (#7932)
32e4311 
When PR #7918 was submitted, a test wasn't added along with it.
@bader bader deleted the remote_san_error branch January 5, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fznamznon Fznamznon Fznamznon approved these changes

@smanna12 smanna12 smanna12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@premanandrao @smanna12 @bader @againull @Fznamznon