[SYCL] Add device::get_info<info::device::aspects> specialisation #7937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 22, 2022 08:57
Defined new specialisation to return vector of aspects supported on the current device. Linux symbol update provided, Windows one still needs adding.
Tests using the default mock platform and device in PiMockPlugin and tests for presence of relevant aspects.
| try { | ||
| return !impl->has(Aspect); | ||
| } catch (const runtime_error &ex) { | ||
| if (ex.get_cl_code() == PI_ERROR_INVALID_DEVICE) |
There was a problem hiding this comment.
That's surprising for me that our device_impl can throw INVALID_DEVICE in has method. What's wrong with asking if a device has an aspect? How can device be invalid in that case?
There was a problem hiding this comment.
device_impl::has is implemented as a switch, it throws PI_ERROR_INVALID_DEVICE in the default case, so I thought it best to handle that one instance and rethrow others. Some testing I did threw this error so I added it, is it best to remove the try and let the exception be thrown normally and assume all aspects have an implemented code path?
steffenlarsen
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specialised function to get a vector of the complete list of supported aspects for the current device, as per Table 25 of the spec.
Initial implementation uses the list of aspects, inserts them into an initial vector with a macro, and tests each using the existing
::has()functionality, removing them form the list if not applicable, returning only what is supported on the device. Thought this would reduce code duplication and could reuse the aspect definition list file. If this isn't appropriate, please do suggest alternatives.The current test works but if it needs further development, do let me know.