Skip to content

[SYCL] Add assert for LangOpts and ParseKind in LanguageOptionsSpecificAttr #7947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

[SYCL] Add assert for LangOpts and ParseKind in LanguageOptionsSpecificAttr #7947

merged 1 commit into from
Jan 9, 2023

Conversation

steffenlarsen
Copy link
Contributor

This commit adds asserts that all attributes deriving from LanguageOptionsSpecificAttr define both a ParseKind and a LangOpts value.

Based on #7450 (comment)

@steffenlarsen
[SYCL] Add assert for LangOpts and ParseKind in LanguageOptionsSpecif…
3c096f9 
…icAttr

This commit adds asserts that all attributes deriving from
LanguageOptionsSpecificAttr define both a ParseKind and a LangOpts
value.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen requested a review from a team as a code owner January 6, 2023 14:11
@steffenlarsen steffenlarsen mentioned this pull request Jan 6, 2023
Merged
@steffenlarsen steffenlarsen temporarily deployed to aws January 6, 2023 14:35 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws January 6, 2023 15:05 — with GitHub Actions Inactive
premanandrao
premanandrao approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't ever come to this part of the code before. With that caveat, this change looks okay to me.

smanna12
smanna12 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@smanna12 smanna12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 03e70b4 into intel:sycl Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@premanandrao premanandrao premanandrao approved these changes

@smanna12 smanna12 smanna12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steffenlarsen @premanandrao @smanna12 @bader