Skip to content

[SYCL] Remove sycl_ext_oneapi_nd_range_reductions docs #7952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

aelovikov-intel
Copy link
Contributor

The extension implementation had been removed mid-2022.

The extension implementation had been removed mid-2022.
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner January 6, 2023 21:35
Copy link
Contributor

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/removed/README.md, the extension specification should be moved from deprecated/ to removed/.

@aelovikov-intel
Copy link
Contributor Author

According to https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/removed/README.md, the extension specification should be moved from deprecated/ to removed/.

There are no specifications there. Is the requirement really up-to-date?

@gmlueck
Copy link
Contributor

gmlueck commented Jan 6, 2023

There are no specifications there. Is the requirement really up-to-date?

Yes, that is still the process. You are the first person to remove a deprecated extension, which is why there are none in that folder yet.

@aelovikov-intel
Copy link
Contributor Author

@intel/llvm-gatekeepers , PR is ready.

@steffenlarsen steffenlarsen merged commit a46efa0 into intel:sycl Jan 9, 2023
@aelovikov-intel aelovikov-intel deleted the remove-red-ext branch May 1, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants