Skip to content

[SYCL] Refactor SYCL path for work_group_size_hint #7961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

steffenlarsen
Copy link
Contributor

This commit refactors the SYCL path for work_group_size_hint, similar to the refactoring for reqd_work_group_size in
#7450. It also fixes an issue where the dimensions of the work-group hint were not correctly reversed.

This commit refactors the SYCL path for work_group_size_hint, similar to
the refactoring for reqd_work_group_size in
intel#7450. It also fixes an issue where
the dimensions of the work-group hint were not correctly reversed.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen requested a review from a team as a code owner January 9, 2023 14:23
Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen temporarily deployed to aws January 9, 2023 15:28 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws January 9, 2023 18:41 — with GitHub Actions Inactive
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had minor comments/nits.

Signed-off-by: Larsen, Steffen <[email protected]>
Copy link
Contributor

@smanna12 smanna12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steffenlarsen steffenlarsen temporarily deployed to aws January 10, 2023 23:45 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws January 11, 2023 19:25 — with GitHub Actions Inactive
@bader bader merged commit ba51bb6 into intel:sycl Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants