-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Add support for templated call operator in functors #7970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: premanandrao <[email protected]>
@intel/llvm-gatekeepers Hi, this is ready for merge. Thank you. |
Hi @tfzhu @yinyangsx |
2 Linux runners are offline. Fixed and task should be started later |
@tfzhu I can't tell what's wrong with |
…ntel#7970)" This reverts commit 11f53ad.
…nctors without call operators (#8047) This PR reverts the support for templated call operators in functors and functors without call operators which were introduced in #7104 and #7970 We found a regression internally with #7104 that #7970 attempted to fix. A subsequent review of #7970 internally, lead to identifying some pre-existing caveats with regards to supporting templated call operators in functor, supporting cases where there are multiple call operators in functor and making sure the right instantiated version is selected etc. In order to better address the pre-existing issues as well as gaps in #7970 , it was decided to revert the above two PRs.
This PR enables kernels to be defined as named function object types, where the operator() member function is templated.
Example: