Skip to content

[SYCL] Support bf16 isnan for sycl::marray<bfloat16, N> #7990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2023
Merged

[SYCL] Support bf16 isnan for sycl::marray<bfloat16, N> #7990

merged 2 commits into from
Jan 13, 2023

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Jan 12, 2023

No description provided.

@jinge90 jinge90 requested a review from a team as a code owner January 12, 2023 03:29
@jinge90
Copy link
Contributor Author

jinge90 commented Jan 12, 2023

Hi, @JackAKirk and @gmlueck
As we discussed in #7958 , this PR aims to support sycl::marray<bfloat16, N> for isnan.

romanovvlad
romanovvlad reviewed Jan 12, 2023
View reviewed changes
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test in https://github.com/intel/llvm-test-suite ?

@jinge90 jinge90 temporarily deployed to aws January 12, 2023 10:31 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws January 13, 2023 08:00 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws January 13, 2023 08:31 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Jan 13, 2023

/verify with intel/llvm-test-suite#1509

@jinge90
Copy link
Contributor Author

jinge90 commented Jan 13, 2023

Could you please add a test in https://github.com/intel/llvm-test-suite ?

Hi, @romanovvlad
The test is in intel/llvm-test-suite#1509

@bader bader merged commit 25a3813 into intel:sycl Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanovvlad romanovvlad romanovvlad approved these changes

@JackAKirk JackAKirk JackAKirk approved these changes

@gmlueck gmlueck Awaiting requested review from gmlueck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jinge90 @romanovvlad @JackAKirk @bader