Skip to content

[SYCL] Add missing include to JITContext.h #8004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2023
Merged

[SYCL] Add missing include to JITContext.h #8004

merged 1 commit into from
Jan 13, 2023

Conversation

sergey-semenov
Copy link
Contributor

Fix unique_lock not being found during compilation.

@sergey-semenov
[SYCL] Add missing include to JITContext.h
0204c48 
Fix unique_lock not being found during compilation.
sommerlukas
sommerlukas approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@sommerlukas sommerlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this.

Out of interest: On which platform did this fail, or is this related to recent changes to branch sycl? Compiled just fine in the PR on my machine.

@sergey-semenov sergey-semenov temporarily deployed to aws January 13, 2023 13:05 — with GitHub Actions Inactive
@sergey-semenov
Copy link
Contributor Author

I've run into this when doing a local build on RHEL 9.0.

@sergey-semenov sergey-semenov temporarily deployed to aws January 13, 2023 14:11 — with GitHub Actions Inactive
@BrannonKing
Copy link

I ran into this today on current Manjaro with gcc v12.2 and -j 10.

@sergey-semenov sergey-semenov merged commit fee6eb7 into intel:sycl Jan 13, 2023
@sergey-semenov sergey-semenov deleted the addinclude branch January 13, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sommerlukas sommerlukas sommerlukas approved these changes

@victor-eds victor-eds Awaiting requested review from victor-eds

@Naghasan Naghasan Awaiting requested review from Naghasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergey-semenov @BrannonKing @sommerlukas