Skip to content

[SYCL-MLIR] Generate i1 for scalar Boolean values #8010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 23, 2023
Merged

[SYCL-MLIR] Generate i1 for scalar Boolean values #8010

merged 15 commits into from
Jan 23, 2023

Conversation

victor-eds
Copy link
Contributor

Keep using i8 for memory Boolean values.

Signed-off-by: Victor Perez [email protected]

@victor-eds victor-eds added the sycl-mlir Pull requests or issues for sycl-mlir branch label Jan 13, 2023
@victor-eds victor-eds self-assigned this Jan 13, 2023
whitneywhtsang
whitneywhtsang previously approved these changes Jan 13, 2023
View reviewed changes
whitneywhtsang
whitneywhtsang reviewed Jan 13, 2023
View reviewed changes
@whitneywhtsang whitneywhtsang dismissed their stale review January 13, 2023 23:05

Added review comment #8010 (comment)

etiotto
etiotto reviewed Jan 16, 2023
View reviewed changes
Copy link

@etiotto etiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - after @whitneywhtsang comments are addressed,

etiotto
etiotto reviewed Jan 16, 2023
View reviewed changes
@victor-eds
Copy link
Contributor Author

DRAFTED: Need to push easy fix for unary & operator on Boolean variables.

@victor-eds victor-eds marked this pull request as draft January 17, 2023 11:13
whitneywhtsang
whitneywhtsang previously approved these changes Jan 17, 2023
View reviewed changes
@etiotto
Copy link

etiotto commented Jan 18, 2023

@whitneywhtsang FYI this PR is back to a draft so previous approvals are no longer relevant. We will need to review it again once is out of draft status.

@whitneywhtsang
Copy link
Contributor

@whitneywhtsang FYI this PR is back to a draft so previous approvals are no longer relevant. We will need to review it again once is out of draft status.

Sure, I will review again when there are new changes.

victor-eds
victor-eds commented Jan 18, 2023
View reviewed changes
@victor-eds victor-eds marked this pull request as ready for review January 18, 2023 16:29
This was referenced Jan 18, 2023
Open
Open
victor-eds
victor-eds commented Jan 18, 2023
View reviewed changes
whitneywhtsang
whitneywhtsang reviewed Jan 19, 2023
View reviewed changes
victor-eds
victor-eds commented Jan 20, 2023
View reviewed changes
@victor-eds victor-eds mentioned this pull request Jan 20, 2023
Closed
etiotto
etiotto reviewed Jan 20, 2023
View reviewed changes
@whitneywhtsang whitneywhtsang self-requested a review January 20, 2023 21:56
@whitneywhtsang whitneywhtsang dismissed their stale review January 20, 2023 21:57

test suite regression

@victor-eds victor-eds mentioned this pull request Jan 23, 2023
Open
@whitneywhtsang whitneywhtsang linked an issue Jan 23, 2023 that may be closed by this pull request
Lambda capture of Boolean values by reference not working #8066
Closed
@victor-eds victor-eds merged commit d356268 into intel:sycl-mlir Jan 23, 2023
@victor-eds victor-eds deleted the memtypes branch January 23, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiotto etiotto etiotto approved these changes

@whitneywhtsang whitneywhtsang whitneywhtsang approved these changes

@sommerlukas sommerlukas Awaiting requested review from sommerlukas

@Naghasan Naghasan Awaiting requested review from Naghasan

Assignees

@victor-eds victor-eds

Labels
sycl-mlir Pull requests or issues for sycl-mlir branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lambda capture of Boolean values by reference not working
3 participants
@victor-eds @etiotto @whitneywhtsang