Skip to content

[SYCL] Update simple-sycl-app.cpp example in GetStartedGuide.md #8025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Jan 17, 2023

Fixes #5738

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner January 17, 2023 21:39
@bader
Copy link
Contributor

bader commented Jan 17, 2023

Addresses #5738

If you use one of the keywords from the list documented here: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword. The issue will be closed automatically with PR merge. ;)

@zjin-lcf
Copy link
Contributor

Can you keep both versions instead of overwriting the previous one ? Then people can see the changes. Thanks.

@aelovikov-intel
Copy link
Contributor Author

Can you keep both versions instead of overwriting the previous one ? Then people can see the changes. Thanks.

I don't think it's a good idea. We need to promote modern syntax and not something that has been deprecated and will be removed soon.

@aelovikov-intel
Copy link
Contributor Author

@intel/dpcpp-doc-reviewers , ping.

@bader bader merged commit e85232c into intel:sycl Jan 18, 2023
@aelovikov-intel aelovikov-intel deleted the update-getting-started branch May 1, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modernize code examples from the GetStartedGuide.md
3 participants