[SYCL] Throw exception when selected device is not in context #8052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In accordance with the SYCL 2020 specification a device selector should always pick from all available devices. Likewise, the queue constructor should throw an exception if the selected device is not in the given context. This commit fixes the device selection behavior when a context is specified, throwing the corresponding exception. Note that this only affects SYCL 2020 style device selectors. Signed-off-by: Larsen, Steffen <[email protected]>
|
/verify with intel/llvm-test-suite#1527 |
againull
approved these changes
Jan 20, 2023
|
Failed Test on CUDA: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with the SYCL 2020 specification a device selector should always pick from all available devices. Likewise, the queue constructor should throw an exception if the selected device is not in the given context. This commit fixes the device selection behavior when a context is specified, throwing the corresponding exception. Note that this only affects SYCL 2020 style device selectors.