Skip to content

[SYCL] Ignore placeholder template parameter for accessor #8071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 31, 2023
Merged

[SYCL] Ignore placeholder template parameter for accessor #8071

merged 13 commits into from
Jan 31, 2023

Conversation

maarquitos14
Copy link
Contributor

According to SYCL 2020 spec, placeholder template parameter has no bearing in whether the accessor is a placeholder or not, it is now solely determined by the constructor.

@maarquitos14
Ignore placeholder template parameter for accessor
ef67b84 
According to SYCL 2020 spec, placeholder template parameter has no
bearing in whether the accessor is a placeholder or not, it is now
solely determined by the constructor.
@maarquitos14 maarquitos14 requested a review from a team as a code owner January 20, 2023 18:09
@bader
Copy link
Contributor

bader commented Jan 20, 2023

\testwin

\ -> /

@maarquitos14
Copy link
Contributor Author

/testwin

@maarquitos14 maarquitos14 temporarily deployed to aws January 20, 2023 18:24 — with GitHub Actions Inactive
@maarquitos14 maarquitos14 temporarily deployed to aws January 23, 2023 13:07 — with GitHub Actions Inactive
@maarquitos14 maarquitos14 temporarily deployed to aws January 23, 2023 13:38 — with GitHub Actions Inactive
AlexeySachkov
AlexeySachkov reviewed Jan 24, 2023
View reviewed changes
@maarquitos14 maarquitos14 temporarily deployed to aws January 25, 2023 10:06 — with GitHub Actions Inactive
@maarquitos14 maarquitos14 temporarily deployed to aws January 25, 2023 12:03 — with GitHub Actions Inactive
@maarquitos14 maarquitos14 temporarily deployed to aws January 25, 2023 12:36 — with GitHub Actions Inactive
@maarquitos14 maarquitos14 temporarily deployed to aws January 25, 2023 13:07 — with GitHub Actions Inactive
@maarquitos14
Copy link
Contributor Author

@KseniyaTikhomirova @intel/llvm-reviewers-runtime - Friendly ping.

dm-vodopyanov
dm-vodopyanov reviewed Jan 30, 2023
View reviewed changes
@maarquitos14 maarquitos14 temporarily deployed to aws January 30, 2023 14:39 — with GitHub Actions Inactive
@maarquitos14
Add missing Windows symbols
bee29ac 
Signed-off-by: Maronas, Marcos <[email protected]>
@maarquitos14
Fixing Windows ABI break.
7b5d154 
Signed-off-by: Maronas, Marcos <[email protected]>
@maarquitos14
Fixing Windows ABI break
e7e8d9a 
Signed-off-by: Maronas, Marcos <[email protected]>
dm-vodopyanov
dm-vodopyanov reviewed Jan 30, 2023
View reviewed changes
@maarquitos14 maarquitos14 temporarily deployed to aws January 30, 2023 16:20 — with GitHub Actions Inactive
@maarquitos14 maarquitos14 temporarily deployed to aws January 30, 2023 17:22 — with GitHub Actions Inactive
aelovikov-intel
aelovikov-intel reviewed Jan 30, 2023
View reviewed changes
@maarquitos14 maarquitos14 temporarily deployed to aws January 30, 2023 20:56 — with GitHub Actions Inactive
@maarquitos14
Copy link
Contributor Author

/testwin

@maarquitos14 maarquitos14 temporarily deployed to aws January 30, 2023 21:46 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov merged commit 2b1d320 into intel:sycl Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov left review comments

@aelovikov-intel aelovikov-intel aelovikov-intel left review comments

@dm-vodopyanov dm-vodopyanov dm-vodopyanov approved these changes

@KseniyaTikhomirova KseniyaTikhomirova Awaiting requested review from KseniyaTikhomirova KseniyaTikhomirova is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maarquitos14 @bader @dm-vodopyanov @AlexeySachkov @aelovikov-intel