Skip to content

[SYCL-MLIR] Add memref of sub_group and minimum to list of SYCL memrefs #8079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2023
Merged

[SYCL-MLIR] Add memref of sub_group and minimum to list of SYCL memrefs #8079

merged 1 commit into from
Jan 23, 2023

Conversation

whitneywhtsang
Copy link
Contributor

This PR makes the following tests pass:

SYCL :: SubGroup/broadcast_fp64.cpp   
SYCL :: SubGroup/reduce_spirv13_fp16.cpp
SYCL :: SubGroup/reduce_spirv13_fp64.cpp 
SYCL :: SubGroup/scan_spirv13_fp16.cpp

Signed-off-by: Tsang, Whitney [email protected]

@whitneywhtsang whitneywhtsang added the sycl-mlir Pull requests or issues for sycl-mlir branch label Jan 23, 2023
@whitneywhtsang whitneywhtsang self-assigned this Jan 23, 2023
victor-eds
victor-eds approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@victor-eds victor-eds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whitneywhtsang whitneywhtsang merged commit 9eb3039 into intel:sycl-mlir Jan 23, 2023
@whitneywhtsang whitneywhtsang deleted the constructor branch January 23, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victor-eds victor-eds victor-eds approved these changes

@sommerlukas sommerlukas Awaiting requested review from sommerlukas

@etiotto etiotto Awaiting requested review from etiotto

Assignees

@whitneywhtsang whitneywhtsang

Labels
sycl-mlir Pull requests or issues for sycl-mlir branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whitneywhtsang @victor-eds