[SYCL] Add code location data to XPTI trace in case of exception thrown #8101

KseniyaTikhomirova · 2023-01-25T15:25:52Z

Adds extra information about code location of command submission to exception message.
Now instrumented a few sycl::queue non-variadic methods which takes code location from parameter.
Also instrumented variadic parallel_for where code location is extracted from kernel info.

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

sycl/include/sycl/queue.hpp

sycl/source/CMakeLists.txt

sycl/source/detail/global_handler.cpp

xpti/src/xpti_proxy.cpp

xptifw/src/CMakeLists.txt

KseniyaTikhomirova · 2023-01-25T15:45:05Z

xptifw/src/xpti_trace_framework.cpp

@@ -959,9 +959,10 @@ class Framework {
      // have 'nullptr' for both the Parent and Object only if UserData is
      // provided and the trace_point_type is function_begin/function_end.
      // This allows us to trace function calls without too much effort.
-      std::array<trace_point_type_t, 13> AllowedTypes = {
+      std::array<trace_point_type_t, 14> AllowedTypes = {


also to clarify with Vasanth if there was an idea that could block me on there changes.

KseniyaTikhomirova · 2023-01-25T15:47:27Z

to run clang-format on all files. Some commits were uploaded skipping this step.

sycl/include/sycl/queue.hpp

sycl/source/CMakeLists.txt

sycl/source/detail/global_handler.cpp

KseniyaTikhomirova · 2023-01-26T11:25:05Z

sycl/unittests/xpti_trace/CMakeLists.txt

@@ -0,0 +1,8 @@
+add_subdirectory(xptitest_subscriber)
+
+add_definitions(-DXPTI_ENABLE_INSTRUMENTATION -gdwarf-4 -O0)


sycl/unittests/xpti_trace/xptitest_subscriber/CMakeLists.txt

sycl/unittests/xpti_trace/xptitest_subscriber/XPTISubscriber.cpp

xpti/CMakeLists.txt

xptifw/src/CMakeLists.txt

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

sycl/source/detail/global_handler.cpp

sycl/source/detail/scheduler/commands.cpp

sycl/source/detail/scheduler/commands.hpp

sycl/tools/sycl-trace/sycl_trace_collector.cpp

sycl/unittests/xpti_trace/xptitest_subscriber/XPTISubscriber.cpp

sycl/unittests/xpti_trace/QueueApiFailures.cpp

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

tovinkere

LGTM

steffenlarsen

Overall the runtime changes look good! Couple of small comments.

Could you please add a summary to the PR description?

sycl/unittests/xpti_trace/QueueApiFailures.cpp

sycl/source/detail/global_handler.cpp

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

steffenlarsen

LGTM!

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

bader · 2023-03-09T06:08:42Z

@KseniyaTikhomirova, please, address this comment from @steffenlarsen:

Could you please add a summary to the PR description?

I think you missed one suggestion from me - #8101 (comment). Do you mind making this change?

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova · 2023-03-09T12:17:09Z

@KseniyaTikhomirova, please, address this comment from @steffenlarsen:

Could you please add a summary to the PR description?

I think you missed one suggestion from me - #8101 (comment). Do you mind making this change?

Hi, added description and fixed your comment. Thank you.

bader · 2023-03-09T18:02:26Z

@KseniyaTikhomirova, there are failures in post-commit. Please, address them ASAP. NOTE: there are a few different issues, please, read all logs. https://github.com/intel/llvm/actions/runs/4376461454

KseniyaTikhomirova · 2023-03-09T18:43:26Z

@KseniyaTikhomirova, there are failures in post-commit. Please, address them ASAP. NOTE: there are a few different issues, please, read all logs. https://github.com/intel/llvm/actions/runs/4376461454

working on it, thanks

KseniyaTikhomirova · 2023-03-09T19:09:29Z

#8598 waiting for CI checks

bader · 2023-03-09T19:13:15Z

#8598 waiting for CI checks

Thanks. I updated PR title. Please, let me know if you have any comments.

KseniyaTikhomirova · 2023-03-09T19:18:24Z

#8598 waiting for CI checks

Thanks. I updated PR title. Please, let me know if you have any comments.

All is perfect. Sorry and thanks a lot.

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova added 23 commits January 9, 2023 06:21

Add sycl level stream to xpti

bbbe150

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

not working draft to emit notification

1e26df7

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

add draft for test

f31d458

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Add more tests

b755296

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Put kernel info to tls (not working)

a5bbf26

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Fix parralel_for code info extraction

83da734

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Add basic unittests for other APIs

b6a3338

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

restore handler.hpp state

0e70171

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Add exception desciption to message

a64195f

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

change string types

2eafcbc

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Save code location for async commands

35e9755

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Try to trace failure in host task

0f8ff4d

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Add handling to host task exceptions

e9b046a

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Finish host task submission handling

8cd2264

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Add kernel async execution handling

0b39cc4

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Add small timeout to make test stable

e43141c

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

small update for sycl-trace

3a0e455

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Merge branch 'sycl' into xpti_tracepoints

23d1b5f

Add missed instrumentation to queue::parallel_for

7792103

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

change string format to better parse it

1813df1

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Add details to test

89f9eed

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Rework way of code_location report

043ffdc

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

Update unit tests

b7130e6

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to aws January 25, 2023 15:40 — with GitHub Actions Inactive

KseniyaTikhomirova commented Jan 25, 2023

View reviewed changes

KseniyaTikhomirova commented Jan 26, 2023

View reviewed changes

code clean up

2522163

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to aws January 26, 2023 12:23 — with GitHub Actions Inactive

fix LIT

6f65c99

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

bader reviewed Mar 3, 2023

View reviewed changes

Fix code-review comments

3d2733f

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to aws March 6, 2023 11:16 — with GitHub Actions Inactive

KseniyaTikhomirova temporarily deployed to aws March 6, 2023 13:19 — with GitHub Actions Inactive

tovinkere approved these changes Mar 6, 2023

View reviewed changes

KseniyaTikhomirova temporarily deployed to aws March 7, 2023 00:27 — with GitHub Actions Inactive

KseniyaTikhomirova temporarily deployed to aws March 7, 2023 13:25 — with GitHub Actions Inactive

steffenlarsen approved these changes Mar 7, 2023

View reviewed changes

sycl/unittests/xpti_trace/QueueApiFailures.cpp Outdated Show resolved Hide resolved

sycl/source/detail/global_handler.cpp Outdated Show resolved Hide resolved

KseniyaTikhomirova temporarily deployed to aws March 7, 2023 14:18 — with GitHub Actions Inactive

fix comments

4bfed74

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

steffenlarsen approved these changes Mar 7, 2023

View reviewed changes

KseniyaTikhomirova temporarily deployed to aws March 7, 2023 18:21 — with GitHub Actions Inactive

Fix function definition

b8ccd32

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to aws March 8, 2023 17:50 — with GitHub Actions Inactive

KseniyaTikhomirova temporarily deployed to aws March 8, 2023 19:53 — with GitHub Actions Inactive

KseniyaTikhomirova temporarily deployed to aws March 9, 2023 04:16 — with GitHub Actions Inactive

KseniyaTikhomirova temporarily deployed to aws March 9, 2023 04:57 — with GitHub Actions Inactive

fix comment

c2a3cb7

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to aws March 9, 2023 12:43 — with GitHub Actions Inactive

KseniyaTikhomirova temporarily deployed to aws March 9, 2023 13:20 — with GitHub Actions Inactive

bader merged commit f90e9d8 into intel:sycl Mar 9, 2023

againull pushed a commit that referenced this pull request Mar 9, 2023

[SYCL][XPTI][NFC] Fix compiler warnings introduced by #8101 (#8598)

01f7041

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

FreddyLeaf pushed a commit that referenced this pull request Mar 10, 2023

[SYCL][XPTI][NFC] Fix compiler warnings introduced by #8101 (#8598)

fb09533

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

		@@ -0,0 +1,8 @@
		add_subdirectory(xptitest_subscriber)

		add_definitions(-DXPTI_ENABLE_INSTRUMENTATION -gdwarf-4 -O0)

[SYCL] Add code location data to XPTI trace in case of exception thrown #8101

[SYCL] Add code location data to XPTI trace in case of exception thrown #8101

Uh oh!

Conversation

KseniyaTikhomirova commented Jan 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KseniyaTikhomirova Jan 25, 2023

Choose a reason for hiding this comment

Uh oh!

KseniyaTikhomirova commented Jan 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KseniyaTikhomirova Jan 26, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tovinkere left a comment

Choose a reason for hiding this comment

Uh oh!

steffenlarsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

steffenlarsen left a comment

Choose a reason for hiding this comment

Uh oh!

bader commented Mar 9, 2023

Uh oh!

KseniyaTikhomirova commented Mar 9, 2023

Uh oh!

bader commented Mar 9, 2023

Uh oh!

KseniyaTikhomirova commented Mar 9, 2023

Uh oh!

KseniyaTikhomirova commented Mar 9, 2023

Uh oh!

bader commented Mar 9, 2023

Uh oh!

KseniyaTikhomirova commented Mar 9, 2023

Uh oh!

Uh oh!

KseniyaTikhomirova commented Jan 25, 2023 •

edited

Loading