[SYCL] Change signature of host_accessor::get_pointer for SYCL 2020 #8109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYCL 2020 specifies that the `get_pointer` member should now return a raw pointer for based on `value_type` and should be `noexcept`. This commit changes the signature of `get_pointer` for host accessors. Note that `AccessorBaseHost::getPtr` cannot be made `noexcept` currently as it would be an ABI break. This does not limit the functionality of these changes, but should be changed during next ABI break. Signed-off-by: Larsen, Steffen <[email protected]>
|
/verify with intel/llvm-test-suite#1546 |
|
/testwin |
dm-vodopyanov
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL 2020 specifies that the
get_pointermember should now return a raw pointer for based onvalue_typeand should benoexcept. This commit changes the signature ofget_pointerfor host accessors.Note that
AccessorBaseHost::getPtrcannot be madenoexceptcurrently as it would be an ABI break. This does not limit the functionality of these changes, but should be changed during next ABI break.