[SYCL] Fix a race condition when enqueueing an interop kernel #8111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piKernelSetArg isn't supposed to be called from different threads on the same kernel.
|
Failed Tests (1): |
bader
requested changes
Jan 27, 2023
bader
approved these changes
Jan 27, 2023
romanovvlad
reviewed
Jan 27, 2023
| // cache, others (e.g. interoperability kernels) share a single mutex. | ||
| // TODO consider adding a PiKernel -> mutex map for allowing to enqueue | ||
| // different PiKernel's in parallel. | ||
| static std::mutex NoncacheableEnqueueMutex; |
There was a problem hiding this comment.
It would be probably better to have an std::mutexstored in kernel_impl. So, we do not serialize submission of different sycl::kernels.
There was a problem hiding this comment.
@romanovvlad I tend to agree, although wouldn't this mutex need to be tied to pi_kernel like described in the comment above? Otherwise we will run into issues if two interop sycl::kernel are created with the same native kernel.
sergey-semenov
added a commit
to sergey-semenov/llvm
that referenced
this pull request
Jan 31, 2023
Switch from using a single mutex to one per kernel when enqueueing interoperability kernels. Compared to the original solution (intel#8111), this allows to enqueue different interop SYCL kernels in parallel, but leaves out an edge case where two SYCL kernels were created with the same native handle.
sergey-semenov
added a commit
that referenced
this pull request
Feb 2, 2023
Switch from using a single mutex to one per kernel when enqueueing interoperability kernels. Compared to the original solution (#8111), this allows to enqueue different interop SYCL kernels in parallel, but leaves out an edge case where two SYCL kernels were created with the same native handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
piKernelSetArg isn't supposed to be called from different threads on the same kernel.