Skip to content

Fix alignment of generated type #8118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix alignment of generated type #8118

merged 1 commit into from
Jan 31, 2023

Conversation

elizabethandrews
Copy link
Contributor

@elizabethandrews elizabethandrews commented Jan 26, 2023 •
edited
Loading

Alignment can be explicitly specified on records/fields using attribute. Copy attributes from original type to compiler generated types to maintain same alignment in generated types

@elizabethandrews elizabethandrews requested a review from a team as a code owner January 26, 2023 23:22
@elizabethandrews elizabethandrews temporarily deployed to aws January 26, 2023 23:51 — with GitHub Actions Inactive
@elizabethandrews elizabethandrews temporarily deployed to aws January 27, 2023 00:27 — with GitHub Actions Inactive
Fznamznon
Fznamznon approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@Fznamznon Fznamznon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.
Does it somehow affect integration header (just curious)?

@elizabethandrews
Copy link
Contributor Author

Looks ok. Does it somehow affect integration header (just curious)?

I wouldn't expect it to since integration header is generated based on offsets/size of field in original kernel object and not what we generate but I will verify this.

@elizabethandrews
Copy link
Contributor Author

Looks ok. Does it somehow affect integration header (just curious)?

I wouldn't expect it to since integration header is generated based on offsets/size of field in original kernel object and not what we generate but I will verify this.

I checked integration header with and without this patch and it is the same as expected

@elizabethandrews
Copy link
Contributor Author

ping @intel/llvm-gatekeepers

@steffenlarsen
Copy link
Contributor

Failed Tests (1):
SYCL :: dword_atomic_smoke.cpp
Fixed with intel/llvm-test-suite#1552

@steffenlarsen steffenlarsen merged commit daedd57 into intel:sycl Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fznamznon Fznamznon Fznamznon approved these changes

@smanna12 smanna12 smanna12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elizabethandrews @steffenlarsen @Fznamznon @smanna12