[SYCL] Set specialization constants in sycl::compile #8166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes sycl::compile set specialization constants. The functionailty for this is combined with that used by sycl::build. Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
approved these changes
Jan 31, 2023
| } | ||
| } | ||
| } | ||
| setSpecializationConstants(InputImpl, NativePrg, Plugin); |
There was a problem hiding this comment.
Should we fold enableITTAnnotationsIfNeeded(NativePrg, Plugin) into the helper as well?
There was a problem hiding this comment.
We cannot fully merge it as it is used in another place that sets specialization constants differently. However, we may as well call it inside setSpecializationConstants.
Signed-off-by: Larsen, Steffen <[email protected]>
|
/testwin |
|
/verify with intel/llvm-test-suite#1560 |
aelovikov-intel
approved these changes
Feb 1, 2023
Signed-off-by: Larsen, Steffen <[email protected]>
|
/verify with intel/llvm-test-suite#1560 |
Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes
sycl::compileset specialization constants. The functionality for this is combined with that used bysycl::build.