[SYCL][Test] Fix incorrect usage of host accessor #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please provide more detailed description for the problem you are addressing. |
bader
changed the title
The test tries to create second host accessor to the buffer while the first one still alive. This leads to hang. The patch moves the first host accessor to the scope so it is destructed before construction of the second host accessor. Signed-off-by: Vlad Romanov <[email protected]>
romanovvlad
force-pushed
the
private/vromanov/FixTest2
branch
from
b4cfce2 to
600b163
Compare
Done, please check if OK. |
vladimirlaz
approved these changes
Nov 12, 2019
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Nov 30, 2020
Added two new workflows: for in-tree and out-of-tree configurations. Each of them features building and testing the translator for each push or pull request to master and release branches and nightly build as well. In-tree workflow also enables builds on Windows and macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vlad Romanov [email protected]