Skip to content

[SYCL] Fix to make sure ONEAPI_DEVICE_SELECTOR is case insensitive #8238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2023
Merged

[SYCL] Fix to make sure ONEAPI_DEVICE_SELECTOR is case insensitive #8238

merged 1 commit into from
Feb 10, 2023

Conversation

cperkinsintel
Copy link
Contributor

@cperkinsintel cperkinsintel commented Feb 7, 2023 •
edited
Loading

Simple fix to make sure ONEAPI_DEVICE_SELECTOR is case insensitive

tests added here: intel/llvm-test-suite#1579

Signed-off-by: Chris Perkins [email protected]

@cperkinsintel cperkinsintel requested a review from a team as a code owner February 7, 2023 21:43
@cperkinsintel cperkinsintel mentioned this pull request Feb 7, 2023
Merged
@cperkinsintel cperkinsintel temporarily deployed to aws February 7, 2023 22:08 — with GitHub Actions Inactive
steffenlarsen
steffenlarsen approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cperkinsintel cperkinsintel temporarily deployed to aws February 8, 2023 23:58 — with GitHub Actions Inactive
@cperkinsintel
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1579

@bader
Copy link
Contributor

bader commented Feb 9, 2023

PR title style suggestion: fix -> Fix

@cperkinsintel
Copy link
Contributor Author

cperkinsintel commented Feb 10, 2023 •
edited by againull
Loading

the failing test ESIMD/imulh_umulh.cpp is unrelated to this PR and known (there is a tracker for it).

@cperkinsintel cperkinsintel changed the title [SYCL] fix to make sure ONEAPI_DEVICE_SELECTOR is case insensitive [SYCL] Fix to make sure ONEAPI_DEVICE_SELECTOR is case insensitive Feb 10, 2023
@cperkinsintel
Copy link
Contributor Author

and the failure in Plugin/interop-opencl.cpp failure was fixed with #8251

@againull againull merged commit 1ed2378 into intel:sycl Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-semenov sergey-semenov sergey-semenov approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cperkinsintel @bader @sergey-semenov @steffenlarsen @againull