Skip to content

[OpenCL] Add Transform passes which support SYCL and OCL #8250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

[OpenCL] Add Transform passes which support SYCL and OCL #8250

wants to merge 0 commits into from

Conversation

cdai2
Copy link
Contributor

@cdai2 cdai2 commented Feb 8, 2023

LIT test cases for them are also included.

@cdai2 cdai2 requested a review from a team as a code owner February 8, 2023 13:57
@cdai2
Copy link
Contributor Author

cdai2 commented Feb 8, 2023

This PR is part of #8216. It's created for better code review.

@cdai2 cdai2 requested a review from bader February 8, 2023 13:57
@cdai2 cdai2 requested a review from a team as a code owner February 8, 2023 14:04
@cdai2 cdai2 mentioned this pull request Feb 8, 2023
Closed
@bader
Copy link
Contributor

bader commented Feb 8, 2023

@cdai2, please, fix pre-commit checks.

bader
bader reviewed Feb 8, 2023
View reviewed changes
@wenju-he wenju-he requested a review from a team February 9, 2023 01:36
@bader bader removed the request for review from a team February 9, 2023 01:39
@cdai2
Copy link
Contributor Author

cdai2 commented Feb 9, 2023

@cdai2, please, fix pre-commit checks.

updated.

@cdai2 cdai2 force-pushed the Upload_SYCLTransforms branch from e4911c6 to 8d57ff5 Compare February 9, 2023 04:23
@cdai2 cdai2 temporarily deployed to aws February 9, 2023 04:50 — with GitHub Actions Inactive
bader
bader approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cdai2, we code owners approval to unblock the merge. Due to the bug in CODEOWNERS file, I mentioned here this code must be approved by the tools team. Please, fix CODEOWNERS file ASAP to get reviews for OpenCL patches in time.

wenju-he
wenju-he approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@wenju-he wenju-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdai2 cdai2 temporarily deployed to aws February 9, 2023 13:09 — with GitHub Actions Inactive
@cdai2
Copy link
Contributor Author

cdai2 commented Feb 10, 2023

ping @intel/dpcpp-tools-reviewers. Please review.

@bader
Copy link
Contributor

bader commented Feb 10, 2023

hewj03 approval should be enough to merge.

@bader
Copy link
Contributor

bader commented Feb 10, 2023

@cdai2, I've noticed a comment from @jbrodman related to this patch: #8216 (comment). Do you plan to make additional changes?

@cdai2
Copy link
Contributor Author

cdai2 commented Feb 10, 2023

@cdai2, I've noticed a comment from @jbrodman related to this patch: #8216 (comment). Do you plan to make additional changes?

We preferred to use SYCL. I replied in #8216.

@cdai2 cdai2 force-pushed the Upload_SYCLTransforms branch 2 times, most recently from 9257834 to 63c0701 Compare February 14, 2023 11:11
@cdai2 cdai2 mentioned this pull request Feb 14, 2023
Merged
@cdai2
Copy link
Contributor Author

cdai2 commented Feb 14, 2023

@cdai2, I've noticed a comment from @jbrodman related to this patch: #8216 (comment). Do you plan to make additional changes?

@bader The latest patch changed the folder name from SYCLTransforms to SPMDTransforms.

bader pushed a commit that referenced this pull request Feb 14, 2023
@cdai2
[CI] Change folder name from SYCLTransforms to SPMDTransforms (#8340)
6050d20 
This change is a follow-up of change in #8250 .
@bader bader requested a review from jbrodman February 14, 2023 16:38
@bader bader self-assigned this Feb 14, 2023
Nuullll
Nuullll reviewed Feb 15, 2023
View reviewed changes
@cdai2 cdai2 temporarily deployed to aws February 15, 2023 15:43 — with GitHub Actions Inactive
@bader bader closed this Feb 17, 2023
@bader bader reopened this Feb 17, 2023
@bader bader temporarily deployed to aws February 17, 2023 00:50 — with GitHub Actions Inactive
@bader bader temporarily deployed to aws February 17, 2023 00:59 — with GitHub Actions Inactive
@cdai2 cdai2 closed this Feb 24, 2023
@cdai2 cdai2 force-pushed the Upload_SYCLTransforms branch from 34c0742 to 7589ac9 Compare February 24, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@wenju-he wenju-he wenju-he approved these changes

@Nuullll Nuullll Nuullll approved these changes

@jbrodman jbrodman Awaiting requested review from jbrodman

Assignees

@bader bader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdai2 @bader @wenju-he @Nuullll