Skip to content

[SYCL] Add imf simd emulation APIs to sycl_ext_intel_math #8262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2023

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Feb 9, 2023

CUDA math provides a series of simd intrinsic: https://docs.nvidia.com/cuda/cuda-math-api/group__CUDA__MATH__INTRINSIC__SIMD.html#group__CUDA__MATH__INTRINSIC__SIMD
We provided corresponding APIs in SYCL libdevice which emulates the behaviors of these CUDA simd intrinsic.
The PR adds these APIs to sycl_ext_intel_math header file, so users can invoke them when porting CUDA code to SYCL.

@jinge90
Copy link
Contributor Author

jinge90 commented Feb 9, 2023

/verify with intel/llvm-test-suite#1587

@jinge90 jinge90 temporarily deployed to aws February 9, 2023 08:44 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws February 9, 2023 14:32 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Feb 14, 2023

Hi, @sergey-semenov and @intel/llvm-reviewers-runtime
Could you take a look at this PR?
Thanks very much.

@sergey-semenov
Copy link
Contributor

Is this API covered by an existing extension document?

The changes themselves LGTM.

@jinge90
Copy link
Contributor Author

jinge90 commented Feb 16, 2023

Is this API covered by an existing extension document?

The changes themselves LGTM.

Hi, @sergey-semenov
We are going to provide doc to cover all APIs in sycl_ext_intel_math namespace.
Thanks very much.

@jinge90 jinge90 requested a review from a team February 20, 2023 01:38
@jinge90
Copy link
Contributor Author

jinge90 commented Feb 20, 2023

Hi, @intel/llvm-gatekeepers
Could you help review and merge this PR?
Thanks very much.

@steffenlarsen steffenlarsen merged commit b0bfdfa into intel:sycl Feb 20, 2023
callumfare pushed a commit to callumfare/llvm that referenced this pull request Feb 28, 2023
CUDA math provides a series of simd intrinsic:
https://docs.nvidia.com/cuda/cuda-math-api/group__CUDA__MATH__INTRINSIC__SIMD.html#group__CUDA__MATH__INTRINSIC__SIMD
We provided corresponding APIs in SYCL libdevice which emulates the
behaviors of these CUDA simd intrinsic.
The PR adds these APIs to sycl_ext_intel_math header file, so users can
invoke them when porting CUDA code to SYCL.

---------

Signed-off-by: jinge90 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants