-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Treat profiling as not supported if submit timestamps are not #8279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
With the recent fix to command_submit profiling information query it now requires that the plugin supports piGetDeviceAndHostTimer API. Because of that, we should not report queue profiling as a supported aspect unless both the underlying pi_queue supports profiling and piGetDeviceAndHostTimer is available. In addition, add a feature_not_supported exception when a queue is constructed with enable_profiling property and a device that does not support profiling.
Note that the spec does not currently state that the exception must be thrown in the case described in the commit message, but I don't expect it to be a controversial change (KhronosGroup/SYCL-Docs#359) |
Looks like ESIMD tests assume that queue profiling is supported despite that not being the case with ESIMD emulator (it's just actually checked with this patch). I think the tests should be modified so that profiling is optional there. I noticed, however, that several profiling related functions from the ESIMD emulator backend ( |
@sergey-semenov , as far as I remember, when I brought up ESIMD_EMULATOR backend, |
/verify with intel/llvm-test-suite#1604 |
/verify with intel/llvm-test-suite#1604 |
@dm-vodopyanov @intel/llvm-reviewers-runtime Could you please take a look? |
With the recent fix to command_submit profiling information query it now requires that the plugin supports piGetDeviceAndHostTimer API. Because of that, we should not report queue profiling as a supported aspect unless both the underlying pi_queue supports profiling and piGetDeviceAndHostTimer is available.
In addition, add a feature_not_supported exception when a queue is constructed with enable_profiling property and a device that does not support profiling.