[SYCL][Scheduler] Refactor data transfer scheduler commands #830
Conversation
|
Typo in the commit message: requirment -> requirement. |
I'm planning
The change makes map, unmap and other commands more flexible so they can be used not only for situations when we have host accessor which we need to initialize with host ptr, but for doing map/unmap in cases when we can/must avoid copying which would require additional memory allocation on the host. |
bader
changed the title
Thanks. |
There was a problem hiding this comment.
LGTM aside from the commit message remark made by @bader and a minor nitpick
romanovvlad
force-pushed
the
private/vromanov/CommandsRefactoring1
branch
from
a2f5ec5 to
20fad3d
Compare
The patch makes transfer commands such as map and unmap more flexible. Now they can be used not only for situations when we have host accessor which we need to initialize with host ptr, but for doing map/unmap in cases when we can/must avoid copying which would require additional memory allocation on the host. Signed-off-by: Vlad Romanov <[email protected]>
romanovvlad
force-pushed
the
private/vromanov/CommandsRefactoring1
branch
from
20fad3d to
a9e613c
Compare
|
refactored MemCpyCommandHost in the same way |
* Align with llvm.org on sret/byval parameter attribute types With the latest community changes, the StructRet/ByVal parameter attributes are now required to have a type. Fix the build by: 1. updating the LIT IR to match this policy; 2. adding correct attribute types in backwards translation. Signed-off-by: Artem Gindinson <[email protected]>
Refactored update requirment, map and unmap commands to enable future optimizations of host memory allocations.
Signed-off-by: Vlad Romanov [email protected]