Skip to content

[SYCL][UR] Update unified-runtime #8315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2023
Merged

[SYCL][UR] Update unified-runtime #8315

merged 3 commits into from
Mar 9, 2023

Conversation

jandres742
Copy link
Contributor

@jandres742 jandres742 commented Feb 11, 2023

Update to

oneapi-src/unified-runtime@6fb8e26

Tag: weekly-2023-02-24

Signed-off-by: Jaime Arteaga [email protected]

@jandres742 jandres742 temporarily deployed to aws February 12, 2023 07:05 — with GitHub Actions Inactive
@jandres742
Copy link
Contributor Author

SYCL / Linux / Build + LIT (pull_request_target) https://github.com/intel/llvm/actions/runs/4154130558/jobs/7187700934 failing with:

_deps/unified-runtime-src/source/loader/ur_loader.cpp:36:2: error: extra ';' [-Werror=pedantic]
   36 | };
      |  ^
_deps/unified-runtime-src/source/loader/ur_loader.cpp:43:2: error: extra ';' [-Werror=pedantic]
   43 | };

Posted PR in UR oneapi-src/unified-runtime#254

@jandres742 jandres742 temporarily deployed to aws February 13, 2023 14:27 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws February 13, 2023 16:45 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws February 14, 2023 08:09 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws February 15, 2023 14:48 — with GitHub Actions Inactive
@jandres742
Copy link
Contributor Author

I have identified some issues in tests. Fixing them in my machine and will repost.

@jandres742 jandres742 temporarily deployed to aws February 16, 2023 01:52 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws February 16, 2023 01:56 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws February 16, 2023 06:21 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws February 16, 2023 06:30 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws February 16, 2023 07:37 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws February 16, 2023 08:34 — with GitHub Actions Inactive
@jandres742
Copy link
Contributor Author

@smaslov-intel : do you see why this is failing? https://github.com/intel/llvm/actions/runs/4191948209/jobs/7266948415

All I see is are errors like:

rm: cannot remove '/__w/llvm/llvm/bolt/test/shared-object.test': Permission denied

@smaslov-intel
Copy link
Contributor

@smaslov-intel : do you see why this is failing? https://github.com/intel/llvm/actions/runs/4191948209/jobs/7266948415

All I see is are errors like:

rm: cannot remove '/__w/llvm/llvm/bolt/test/shared-object.test': Permission denied

I don't see either. Did you try to restart it?
@bader : any idea?

@bader
Copy link
Contributor

bader commented Feb 16, 2023

@smaslov-intel : do you see why this is failing? https://github.com/intel/llvm/actions/runs/4191948209/jobs/7266948415
All I see is are errors like:
rm: cannot remove '/__w/llvm/llvm/bolt/test/shared-object.test': Permission denied

I don't see either. Did you try to restart it? @bader : any idea?

No.

@bader
Copy link
Contributor

bader commented Feb 16, 2023

@smaslov-intel : do you see why this is failing? https://github.com/intel/llvm/actions/runs/4191948209/jobs/7266948415

All I see is are errors like:

rm: cannot remove '/__w/llvm/llvm/bolt/test/shared-object.test': Permission denied

@intel/dpcpp-devops-reviewers, could you investigate, please? To reduce the impact on CI jobs we probably should disable broken systems in GitHub Actions.

@jandres742 jandres742 closed this Feb 17, 2023
@jandres742 jandres742 reopened this Mar 3, 2023
@jandres742 jandres742 temporarily deployed to aws March 3, 2023 05:35 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws March 3, 2023 06:21 — with GitHub Actions Inactive
@jandres742 jandres742 closed this Mar 3, 2023
@jandres742 jandres742 reopened this Mar 3, 2023
@jandres742 jandres742 temporarily deployed to aws March 3, 2023 22:58 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws March 3, 2023 23:52 — with GitHub Actions Inactive
@jandres742 jandres742 closed this Mar 6, 2023
@jandres742 jandres742 reopened this Mar 6, 2023
@jandres742 jandres742 temporarily deployed to aws March 6, 2023 05:57 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws March 6, 2023 06:46 — with GitHub Actions Inactive
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpick, otherwise changes look good to me.

Signed-off-by: Jaime Arteaga <[email protected]>
@jandres742 jandres742 temporarily deployed to aws March 7, 2023 22:54 — with GitHub Actions Inactive
@jandres742 jandres742 closed this Mar 8, 2023
@jandres742 jandres742 reopened this Mar 8, 2023
@jandres742 jandres742 temporarily deployed to aws March 8, 2023 08:52 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws March 8, 2023 09:54 — with GitHub Actions Inactive
@jandres742 jandres742 closed this Mar 8, 2023
@jandres742 jandres742 reopened this Mar 8, 2023
@jandres742 jandres742 temporarily deployed to aws March 8, 2023 17:40 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws March 8, 2023 19:32 — with GitHub Actions Inactive
@bader bader requested a review from igchor March 8, 2023 21:32
@jandres742 jandres742 temporarily deployed to aws March 9, 2023 12:24 — with GitHub Actions Inactive
Copy link
Member

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 7df9b5e into intel:sycl Mar 9, 2023
veselypeta pushed a commit to veselypeta/llvm that referenced this pull request Sep 21, 2023
Update to

oneapi-src/unified-runtime@6fb8e26

Tag: weekly-2023-02-24

Signed-off-by: Jaime Arteaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants