[SYCL][Driver] Device link job should not be added for non-existent i… #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nputs When compiling with only libraries (no source) there should be no device linking step added. We were already preventing the library from being added to the link list, but we were still adding the device link. Signed-off-by: Michael D Toguchi <[email protected]>
AGindinson
reviewed
Nov 14, 2019
AGindinson
previously approved these changes
Nov 14, 2019
AGindinson
reviewed
Nov 14, 2019
Signed-off-by: Michael D Toguchi <[email protected]>
AGindinson
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nputs
When compiling with only libraries (no source) there should be no device
linking step added. We were already preventing the library from being added
to the link list, but we were still adding the device link.
Signed-off-by: Michael D Toguchi [email protected]