[SYCL][Scheduler] Refactor commands #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-semenov
previously approved these changes
Nov 15, 2019
7 tasks
romanovvlad
force-pushed
the
private/vromanov/CommandsRefactoring2
branch
from
26f6a95 to
e6bf238
Compare
|
Fixed the compilation error found by pre commit.
|
sergey-semenov
previously approved these changes
Nov 18, 2019
bader
reviewed
Nov 18, 2019
romanovvlad
force-pushed
the
private/vromanov/CommandsRefactoring2
branch
2 times, most recently
from
8b6a75e to
7d93390
Compare
bader
reviewed
Nov 18, 2019
1. Store requirements in all the commands. This prevents potential use after free. 2. Unified way to access stored requirement. For most of the functions that are only one requirement that needs to be stored and accessed. Being able to get it using just parent type(Command) simplifies code which sets dependency 3. Align/Fix variables names across commands Signed-off-by: Vlad Romanov <[email protected]>
romanovvlad
force-pushed
the
private/vromanov/CommandsRefactoring2
branch
from
7d93390 to
09edefe
Compare
bader
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store requirements in all the commands. This prevents potential use
after free.
Unified way to access stored requirement. For most of the functions
that are only one requirement that needs to be stored and accessed.
Being able to get it using just parent type(Command) simplifies code
which sets dependency
Align/Fix variables names across commands
Signed-off-by: Vlad Romanov [email protected]