[SYCL][Matrix] Move elementwise operation under intel namespace and add joint_matrix_apply. #8417

arnamoy10 · 2023-02-21T19:49:44Z

This patch moves the wi_data and wi_element class (and corresponding
operations) in the matrix-intel.hpp file, under the
intel::experimental::matrix namespace. The original implementation is kept (but soon will be deprecated) to make the existing CUDA test cases work.

This patch moves the wi_data and wi_element class (and corresponding operations) in the matrix-intel.hpp file, under the intel::experimental::matrix namespace. It also removes the miarray based implementation of the wi_data class, as the miarray based implementation was needed to support CUDA. The CUDA support will be established through joint_matrix_apply() API and a cuda based get_wi_data() support in tensorcore.cpp file (coming up next).

dkhaldi

LGTM other than reverting the nvptx-tf32 test changes.

sycl/test/check_device_code/matrix/matrix-nvptx-tf32-test.cpp

sycl/include/sycl/ext/oneapi/matrix/matrix-unified.hpp

sycl/include/sycl/ext/oneapi/matrix/matrix-intel.hpp

sycl/include/sycl/ext/oneapi/matrix/matrix-unified.hpp

matrix-unified.hpp, also adding NVIDIA implementation of joint_matrix_apply.

sycl/include/sycl/ext/oneapi/matrix/matrix-intel.hpp

sycl/include/sycl/ext/oneapi/matrix/matrix-unified.hpp

JackAKirk · 2023-03-14T12:15:45Z

Do you have any example on how to put out the warning? I checked the file and did not find anything I can use.

I think that this is the normal way of outputing the deprecation:

llvm/sycl/include/sycl/accessor.hpp

Line 776 in cf245f6

__SYCL2020_DEPRECATED("get_count() is deprecated, please use size() instead")

So I think if you just refer users to joint_matrix_apply in the deprecated message that would be good.

arnamoy10 · 2023-03-14T12:45:38Z

Do you have any example on how to put out the warning? I checked the file and did not find anything I can use.

I think that this is the normal way of outputing the deprecation:

llvm/sycl/include/sycl/accessor.hpp

Line 776 in cf245f6

__SYCL2020_DEPRECATED("get_count() is deprecated, please use size() instead")

So I think if you just refer users to joint_matrix_apply in the deprecated message that would be good.

I added the message, can you please double check if I added in the right place? Thank you

JackAKirk · 2023-03-14T15:05:22Z

Do you have any example on how to put out the warning? I checked the file and did not find anything I can use.

I think that this is the normal way of outputing the deprecation:

llvm/sycl/include/sycl/accessor.hpp

Line 776 in cf245f6

__SYCL2020_DEPRECATED("get_count() is deprecated, please use size() instead")

So I think if you just refer users to joint_matrix_apply in the deprecated message that would be good.

I added the message, can you please double check if I added in the right place? Thank you

LGTM!

dkhaldi

LGTM

arnamoy10 · 2023-03-16T15:56:23Z

@intel/llvm-reviewers-runtime Please help merge this patch ASAP, as there are two feature PRs dependent on this. Thank you

steffenlarsen

LGTM!

bader · 2023-03-16T23:41:55Z

@arnamoy10, please, fix these warnings emitted by clang compiler.
https://github.com/intel/llvm/actions/runs/4440014936/jobs/7793257940

/Users/runner/work/llvm/llvm/build/include/sycl/ext/oneapi/matrix/matrix-unified.hpp:132:26: error: unused parameter 'sg' [-Werror,-Wunused-parameter]
joint_matrix_apply(Group sg, joint_matrix<Group, T, Use, M, N, Layout> &jm,
                         ^
/Users/runner/work/llvm/llvm/build/include/sycl/ext/oneapi/matrix/matrix-unified.hpp:132:73: error: unused parameter 'jm' [-Werror,-Wunused-parameter]
joint_matrix_apply(Group sg, joint_matrix<Group, T, Use, M, N, Layout> &jm,
                                                                        ^
/Users/runner/work/llvm/llvm/build/include/sycl/ext/oneapi/matrix/matrix-unified.hpp:133:24: error: unused parameter 'lambda' [-Werror,-Wunused-parameter]
                   F &&lambda) {
                       ^
3 errors generated.

arnamoy10 · 2023-03-17T00:40:58Z

@arnamoy10, please, fix these warnings emitted by clang compiler. https://github.com/intel/llvm/actions/runs/4440014936/jobs/7793257940

/Users/runner/work/llvm/llvm/build/include/sycl/ext/oneapi/matrix/matrix-unified.hpp:132:26: error: unused parameter 'sg' [-Werror,-Wunused-parameter]
joint_matrix_apply(Group sg, joint_matrix<Group, T, Use, M, N, Layout> &jm,
                         ^
/Users/runner/work/llvm/llvm/build/include/sycl/ext/oneapi/matrix/matrix-unified.hpp:132:73: error: unused parameter 'jm' [-Werror,-Wunused-parameter]
joint_matrix_apply(Group sg, joint_matrix<Group, T, Use, M, N, Layout> &jm,
                                                                        ^
/Users/runner/work/llvm/llvm/build/include/sycl/ext/oneapi/matrix/matrix-unified.hpp:133:24: error: unused parameter 'lambda' [-Werror,-Wunused-parameter]
                   F &&lambda) {
                       ^
3 errors generated.

Thanks for the report. PR here: #8684

…ing namespace for get_wi_data() (#1636) for both ATS-M and PVC. Regarding the namespace change, the tests will pass once [this PR](intel/llvm#8417) gets approved.

intel/llvm#8417 is merged so this is ready for review. --------- Signed-off-by: JackAKirk <[email protected]>

…ing namespace for get_wi_data() (intel/llvm-test-suite#1636) for both ATS-M and PVC. Regarding the namespace change, the tests will pass once [this PR](intel#8417) gets approved.

…suite#1655) intel#8417 is merged so this is ready for review. --------- Signed-off-by: JackAKirk <[email protected]>

arnamoy10 added 2 commits February 21, 2023 11:32

clang-format

628d469

arnamoy10 requested a review from a team as a code owner February 21, 2023 19:49

arnamoy10 requested a review from sergey-semenov February 21, 2023 19:49

arnamoy10 self-assigned this Feb 21, 2023

arnamoy10 requested review from yubingex007-a11y, JackAKirk and dkhaldi February 21, 2023 19:50

arnamoy10 temporarily deployed to aws February 21, 2023 20:07 — with GitHub Actions Inactive

arnamoy10 added 4 commits February 21, 2023 12:33

Adding joint_matrix_apply

54512ea

clang-format

d500be1

Fixing failed tests.

7b856e0

clang-format

c119e5d

arnamoy10 changed the title ~~[SYCL][Matrix] Move elementwise operation under intel namespace.~~ [SYCL][Matrix] Move elementwise operation under intel namespace and add joint_matrix_apply. Feb 21, 2023

dkhaldi reviewed Feb 21, 2023

View reviewed changes

sycl/test/check_device_code/matrix/matrix-nvptx-tf32-test.cpp Outdated Show resolved Hide resolved

sycl/include/sycl/ext/oneapi/matrix/matrix-unified.hpp Show resolved Hide resolved

arnamoy10 temporarily deployed to aws February 21, 2023 20:56 — with GitHub Actions Inactive

revert nvidia test case.

6893479

arnamoy10 temporarily deployed to aws February 22, 2023 16:11 — with GitHub Actions Inactive

JackAKirk reviewed Feb 22, 2023

View reviewed changes

sycl/include/sycl/ext/oneapi/matrix/matrix-intel.hpp Show resolved Hide resolved

JackAKirk reviewed Feb 22, 2023

View reviewed changes

sycl/include/sycl/ext/oneapi/matrix/matrix-unified.hpp Show resolved Hide resolved

arnamoy10 added 2 commits February 23, 2023 07:43

Reverting the removal of NVIDIA wi_data implementation from

8b75f35

matrix-unified.hpp, also adding NVIDIA implementation of joint_matrix_apply.

clang-format

563bdd1

arnamoy10 temporarily deployed to aws February 23, 2023 16:04 — with GitHub Actions Inactive

Fixing test case failure.

d0ef8a7

dkhaldi reviewed Feb 23, 2023

View reviewed changes

sycl/include/sycl/ext/oneapi/matrix/matrix-intel.hpp Outdated Show resolved Hide resolved

sycl/include/sycl/ext/oneapi/matrix/matrix-unified.hpp Outdated Show resolved Hide resolved

arnamoy10 temporarily deployed to aws February 23, 2023 17:03 — with GitHub Actions Inactive

arnamoy10 temporarily deployed to aws February 23, 2023 17:37 — with GitHub Actions Inactive

arnamoy10 added 2 commits March 4, 2023 15:09

Reviewers' comments.

70953ee

clang-format

8210ee0

arnamoy10 temporarily deployed to aws March 5, 2023 03:58 — with GitHub Actions Inactive

clang-format

de8c9ee

arnamoy10 added 2 commits March 14, 2023 05:21

Adding deprecated message for CUDA backend get_wi_data()

9ad9772

clang-format

be8e830

arnamoy10 temporarily deployed to aws March 14, 2023 12:36 — with GitHub Actions Inactive

arnamoy10 added 2 commits March 14, 2023 05:44

Updating deprecation message.

cc038b9

clang-format

7d68835

arnamoy10 temporarily deployed to aws March 14, 2023 13:03 — with GitHub Actions Inactive

arnamoy10 added 2 commits March 14, 2023 08:04

Trying to put deprecated in the right place.

9054c74

clang-format

1fb59ad

arnamoy10 temporarily deployed to aws March 14, 2023 15:26 — with GitHub Actions Inactive

arnamoy10 added 2 commits March 14, 2023 08:36

trying to move deprecated to the correct pos attempt 2

8ed1b9f

clang-format

b24f5c1

arnamoy10 temporarily deployed to aws March 14, 2023 16:03 — with GitHub Actions Inactive

arnamoy10 temporarily deployed to aws March 14, 2023 16:54 — with GitHub Actions Inactive

dkhaldi approved these changes Mar 16, 2023

View reviewed changes

steffenlarsen approved these changes Mar 16, 2023

View reviewed changes

steffenlarsen merged commit f8a16f7 into intel:sycl Mar 16, 2023

arnamoy10 deleted the move_elemwise_ops branch March 16, 2023 18:02

steffenlarsen pushed a commit to intel/llvm-test-suite that referenced this pull request Mar 23, 2023

[SYCL][CUDA] Adds cuda test for joint_matrix_apply. (#1655)

ac564a6

intel/llvm#8417 is merged so this is ready for review. --------- Signed-off-by: JackAKirk <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL][Matrix] Move elementwise operation under intel namespace and add joint_matrix_apply. #8417

[SYCL][Matrix] Move elementwise operation under intel namespace and add joint_matrix_apply. #8417

Uh oh!

arnamoy10 commented Feb 21, 2023 •

edited

Loading

Uh oh!

dkhaldi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JackAKirk commented Mar 14, 2023 •

edited

Loading

Uh oh!

arnamoy10 commented Mar 14, 2023

Uh oh!

JackAKirk commented Mar 14, 2023

Uh oh!

dkhaldi left a comment

Uh oh!

arnamoy10 commented Mar 16, 2023

Uh oh!

steffenlarsen left a comment

Uh oh!

bader commented Mar 16, 2023

Uh oh!

arnamoy10 commented Mar 17, 2023

Uh oh!

Uh oh!

[SYCL][Matrix] Move elementwise operation under intel namespace and add joint_matrix_apply. #8417

[SYCL][Matrix] Move elementwise operation under intel namespace and add joint_matrix_apply. #8417

Uh oh!

Conversation

arnamoy10 commented Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkhaldi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JackAKirk commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arnamoy10 commented Mar 14, 2023

Uh oh!

JackAKirk commented Mar 14, 2023

Uh oh!

dkhaldi left a comment

Choose a reason for hiding this comment

Uh oh!

arnamoy10 commented Mar 16, 2023

Uh oh!

steffenlarsen left a comment

Choose a reason for hiding this comment

Uh oh!

bader commented Mar 16, 2023

Uh oh!

arnamoy10 commented Mar 17, 2023

Uh oh!

Uh oh!

arnamoy10 commented Feb 21, 2023 •

edited

Loading

JackAKirk commented Mar 14, 2023 •

edited

Loading