[ESIMD] Add ext::intel::experimental::esimd::wait() #8434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is a very specific tool to set up a scoreboard dependency, add a use for the given value. It also prevents dead/unused value from optimizing away. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
sarnex
approved these changes
Feb 23, 2023
| @@ -505,6 +505,7 @@ class ESIMDIntrinDescTable { | |||
| {"raw_send2_noresult", | |||
| {"raw.send2.noresult", | |||
| {a(0), a(1), ai1(2), a(3), a(4), a(5), a(6), a(7)}}}, | |||
| {"wait", {"dummy.mov", {a(0)}}}, | |||
There was a problem hiding this comment.
I saw the llvm-test-suite test but should we also add a lit test for the lowering?
There was a problem hiding this comment.
The test intel/llvm-test-suite#1615 does verify the lowering.
Please see the "// CHECK: " lines there.
There was a problem hiding this comment.
Yeah there's some tradeoff because that's technically out of tree and doesn't get run with check-llvm, but I don't think it's a big deal
kychendev
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is a very specific tool to set up a scoreboard dependency, add a use for the given value. It also prevents dead/unused value from optimizing away.