[NFC][SYCL][Fusion] Drop debug messages check in internalization test #8435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing for builds with no assertions. Dropping the `-debug` option and the lines checking for the warning messages due to aborted internalization fixes the test. Signed-off-by: Victor Perez <[email protected]>
|
Test introduced here fixed by this PR. |
victor-eds
referenced
this pull request
Feb 23, 2023
When a pointer to be promoted is stored, internalization is no longer safe to perform. In this case, simply bail out and do not promote the given pointer. Signed-off-by: Victor Perez <[email protected]> Co-authored-by: Alexey Bader <[email protected]>
sommerlukas
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing for builds with no assertions. Dropping the
-debugoption and the lines checking for the warning messages due to aborted internalization fixes the test.