[SYCL] Default initialize group_local_memory_for_overwrite #8472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In accordance with the extension introducing it, the group_local_memory_for_overwrite should default initialize its data. This commit adds this behavior, making it only initialize and synchronize when needed. Additionally it changes the local ID calculation in group_local_memory use the group, as suggested in the TODO. Signed-off-by: Larsen, Steffen <[email protected]>
|
/verify with intel/llvm-test-suite#1619 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with the extension introducing it, the group_local_memory_for_overwrite should default initialize its data. This commit adds this behavior, making it only initialize and synchronize when needed.
Additionally it changes the local ID calculation in group_local_memory use the group, as suggested in the TODO.