Skip to content

[SYCL] Deprecate legacy vector type aliases #8561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexeySachkov
Copy link
Contributor

No description provided.

@AlexeySachkov AlexeySachkov requested a review from a team as a code owner March 7, 2023 14:11
@AlexeySachkov AlexeySachkov requested a review from bso-intel March 7, 2023 14:11
@AlexeySachkov AlexeySachkov temporarily deployed to aws March 7, 2023 20:15 — with GitHub Actions Inactive
@AlexeySachkov AlexeySachkov temporarily deployed to aws March 8, 2023 11:45 — with GitHub Actions Inactive
@AlexeySachkov AlexeySachkov temporarily deployed to aws March 8, 2023 17:58 — with GitHub Actions Inactive
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexeySachkov
Copy link
Contributor Author

The PR doesn't introduce any significant API or functional changes, so it shouldn't cause any problems. Therefore, I don't think that it makes sense to restart CUDA check, I'm going to merge the PR as-is.

@AlexeySachkov AlexeySachkov merged commit 016d68b into intel:sycl Mar 10, 2023
@AlexeySachkov AlexeySachkov deleted the private/asachkov/deprecate-vector-legacy-type-aliases branch March 29, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants