[SYCL] Add OSUtil::getCurrentDSODir() function #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGindinson
reviewed
Nov 20, 2019
The function returns a directory where the current dynamic shared object (libsycl.so or sycl.dll in our case) was found. This can be useful to access files relative to the libsycl.so directory: config files, supplemental libraries, etc. Signed-off-by: Andrew Savonichev <[email protected]>
asavonic
force-pushed
the
private/asavonic/osutils-dso-path
branch
from
c9eb854 to
27700f6
Compare
romanovvlad
reviewed
Nov 21, 2019
Signed-off-by: Andrew Savonichev <[email protected]>
romanovvlad
reviewed
Nov 21, 2019
added 2 commits
November 21, 2019 15:37
Signed-off-by: Andrew Savonichev <[email protected]>
Signed-off-by: Andrew Savonichev <[email protected]>
|
@AlexeySachkov Please, "Resolve conversation" if your comments are addressed. |
romanovvlad
reviewed
Nov 22, 2019
sycl/unittests/CMakeLists.txt
Outdated
Comment on lines
12
to
17
| if (CMAKE_BUILD_TYPE MATCHES "Debug") | ||
| set(sycl_lib "sycld") | ||
| else() | ||
| set(sycl_lib "sycl") | ||
| endif() | ||
|
|
There was a problem hiding this comment.
What is the purpose of this change? Why can't we always use "sycl"?
There was a problem hiding this comment.
Debug tests should link with debug SYCL runtime on Windows, because Microsoft C and C++ runtime are have different ABI in for debug and release.
I made this change because SYCL unittests failed to compile on Windows in Debug build. I can make a separate PR with this change.
Anyway, I forgot to guard this change with if (MSVC), so please don't merge this PR yet.
Signed-off-by: Andrew Savonichev <[email protected]>
asavonic
force-pushed
the
private/asavonic/osutils-dso-path
branch
from
b92dcfd to
af853f2
Compare
romanovvlad
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function returns a directory where the current dynamic shared
object (libsycl.so or sycl.dll in our case) was found.
This can be useful to access files relative to the libsycl.so
directory: config files, supplemental libraries, etc.
Signed-off-by: Andrew Savonichev [email protected]