[CI] Enable SYCL End-to-End tests on Windows for post-commit #8656
Conversation
uditagarwal97
changed the title
|
@bader I've disabled the Basic/build_log E2E test case on Windows as it requires the OCLOC external dependency. I've also created an internal ticket to track the status of this test case and have requested the tools team to install OCLOC on Windows CI. Will re-enable this test case on Windows once OCLOC is installed. |
| run: | | ||
| mkdir build-e2e | ||
| set PATH=%GITHUB_WORKSPACE%\install\bin;%PATH% | ||
| cmake -GNinja -B build-e2e -S.\llvm\sycl\test-e2e -DSYCL_TEST_E2E_TARGETS="${{ inputs.targets }}" -DCMAKE_CXX_COMPILER="clang++" -DLLVM_LIT="..\llvm\llvm\utils\lit\lit.py" ${{ inputs.cmake_args }} |
There was a problem hiding this comment.
I'm not sure if we want clang++ or clang-cl here.
There was a problem hiding this comment.
Previously, I did try experimenting with clang-cl instead of clang++. However, I got a lot of compiler errors. My understanding is that, with Git's Bash, clang++ works fine. However, with U4Win Bash, I had to use clang-cl to run the tests. IDK why this happens, but that's something I observed while playing around with the CI.
@uditagarwal97, please, disable them. Otherwise, they will fail in post-commits for every commit. |
|
@intel/dpcpp-esimd-reviewers reviews, please. We have disabled some ESIMD E2E test cases as they were failing on Windows (#8934 ). |
|
@intel/llvm-gatekeepers The PR is ready! |
This PR (1) enables running Windows Build + LIT + E2E tests during pre-commit testing, (2) Fix windows_test_comment_trigger workflow after #8656
The AWS CUDA testing in pre-commit unwillingly got disabled in #8656. This PR re-enables the AWS CUDA testing in pre-commit.
This PR augments Pavel's work (#7477) on running llvm_test_suite in Windows CI for post-commit testing.
Keeping in mind that the intel/llvm_test_suite repo is getting merged into intel/llvm, this PR tests in-tree SYCL E2E tests.