[SYCL] Introduce thread-safety for kernels and programs cache #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-kanaev
requested review from
alexbatashev,
asavonic,
AlexeySachkov,
romanovvlad and
smaslov-intel
AGindinson
reviewed
Nov 22, 2019
s-kanaev
force-pushed
the
private/s-kanaev/thread-safe-program-kernel-cache
branch
from
a705759 to
2938404
Compare
|
Resolved comments by @AlexeySachkov |
romanovvlad
reviewed
Nov 25, 2019
asavonic
reviewed
Nov 25, 2019
s-kanaev
requested review from
AGindinson,
romanovvlad,
AlexeySachkov and
asavonic
romanovvlad
previously approved these changes
Nov 25, 2019
s-kanaev
force-pushed
the
private/s-kanaev/thread-safe-program-kernel-cache
branch
2 times, most recently
from
2533609 to
05ffed3
Compare
romanovvlad
requested changes
Nov 27, 2019
keryell
reviewed
Nov 28, 2019
asavonic
suggested changes
Nov 28, 2019
romanovvlad
reviewed
Nov 29, 2019
| assert(false && "We've build a program that is already have been built."); | ||
| } | ||
|
|
||
| ProgramWithState->State.store(BS_Built); |
There was a problem hiding this comment.
Can we use more relaxed memory models for all loads and stores you are adding?
There was a problem hiding this comment.
I don't think we may use relaxed memory model here as current (sequentially consistent model) makes other threads to synchronize on this variable.
| state = WithBuildState->State.load(); | ||
| } | ||
|
|
||
| // expected to be null if state eq BuildFailed |
There was a problem hiding this comment.
How the nullptr is handled on the callers side?
There was a problem hiding this comment.
Now there will be an exception thrown according to spec.
s-kanaev
force-pushed
the
private/s-kanaev/thread-safe-program-kernel-cache
branch
2 times, most recently
from
78ba70e to
84fc26a
Compare
asavonic
previously requested changes
Nov 29, 2019
s-kanaev
force-pushed
the
private/s-kanaev/thread-safe-program-kernel-cache
branch
from
84fc26a to
53eebbd
Compare
keryell
reviewed
Dec 3, 2019
|
|
||
| Cache.notifyAllBuild(); | ||
|
|
||
| std::rethrow_exception(std::current_exception()); |
s-kanaev
force-pushed
the
private/s-kanaev/thread-safe-program-kernel-cache
branch
2 times, most recently
from
063ec1d to
b36dc7c
Compare
s-kanaev
force-pushed
the
private/s-kanaev/thread-safe-program-kernel-cache
branch
from
b36dc7c to
ab4c8f2
Compare
romanovvlad
requested changes
Dec 9, 2019
| KernelProgramCache::EntityWithState<RetT> *WithState; | ||
|
|
||
| { | ||
| auto Locked = Acquire(Cache); |
There was a problem hiding this comment.
Please, do not use auto when the type is not clear for the line itself. Please, apply to whole patch.
There was a problem hiding this comment.
Done.
BTW, it is template function. It is intended to not know the exact type here.
s-kanaev
force-pushed
the
private/s-kanaev/thread-safe-program-kernel-cache
branch
2 times, most recently
from
ce17aee to
977858d
Compare
|
@s-kanaev, could you please rebase your patch and resolve merge conflicts? |
s-kanaev
force-pushed
the
private/s-kanaev/thread-safe-program-kernel-cache
branch
from
977858d to
8a4f32f
Compare
Done |
Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
force-pushed
the
private/s-kanaev/thread-safe-program-kernel-cache
branch
from
8a4f32f to
f2620b5
Compare
romanovvlad
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.