[SYCL] Fix sporadic failure in kernel-and-program.cpp #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clEnqueueWriteBuffer operation with `blocking == CL_TRUE' is *not* guaranteed to complete before it returns. It only guarantees that the host pointer (data) can now be re-used or free'ed: an OpenCL runtime either already completed the operation, or (the faulty case) an OpenCL runtime copied data to an internal (temporary) memory and the operation will be executed later. We have to explicitly finish the operation in order to avoid a data race when the faulty case happens. Signed-off-by: Andrew Savonichev <[email protected]>
AlexeySachkov
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clEnqueueWriteBuffer operation with `blocking == CL_TRUE' is not
guaranteed to complete before it returns. It only guarantees that the
host pointer (data) can now be re-used or free'ed: an OpenCL runtime
either already completed the operation, or (the faulty case) an OpenCL
runtime copied data to an internal (temporary) memory and the
operation will be executed later.
We have to explicitly finish the operation in order to avoid a data
race when the faulty case happens.
Signed-off-by: Andrew Savonichev [email protected]