Skip to content

[SYCL][ESIMD] Update the path to CM Emulator release package #8706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

turinevgeny
Copy link
Contributor

Change in the path leads to CI failures.

@turinevgeny turinevgeny requested a review from a team as a code owner March 20, 2023 23:12
@turinevgeny turinevgeny temporarily deployed to aws March 20, 2023 23:38 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws March 21, 2023 00:09 — with GitHub Actions Inactive
@turinevgeny turinevgeny requested a review from a team March 21, 2023 02:43
@bader
Copy link
Contributor

bader commented Mar 21, 2023

@fineg74, @turinevgeny, I still see these failures in pre-commits. Please, disable these tests or fix as soon as possible.

********************
Timed Out Tests (8):
  SYCL :: lsc/lsc_usm_block_load_u8_u16.cpp
  SYCL :: lsc/lsc_usm_block_load_u8_u16_64.cpp
  SYCL :: lsc/lsc_usm_prefetch_u32.cpp
  SYCL :: lsc/lsc_usm_prefetch_u32_64.cpp
  SYCL :: lsc/lsc_usm_prefetch_u32_scalar_off.cpp
  SYCL :: lsc/lsc_usm_prefetch_u64.cpp
  SYCL :: lsc/lsc_usm_prefetch_u64_64.cpp
  SYCL :: lsc/lsc_usm_prefetch_u64_scalar_off.cpp

********************
Failed Tests (25):
  SYCL :: lsc/lsc_surf_load_u16u32.cpp
  SYCL :: lsc/lsc_surf_load_u32.cpp
  SYCL :: lsc/lsc_surf_load_u32_stateless.cpp
  SYCL :: lsc/lsc_surf_load_u64.cpp
  SYCL :: lsc/lsc_surf_load_u64_stateless.cpp
  SYCL :: lsc/lsc_surf_load_u8_u16.cpp
  SYCL :: lsc/lsc_surf_load_u8_u16_stateless.cpp
  SYCL :: lsc/lsc_surf_load_u8u32.cpp
  SYCL :: lsc/lsc_surf_prefetch_u16u32.cpp
  SYCL :: lsc/lsc_surf_prefetch_u32.cpp
  SYCL :: lsc/lsc_surf_prefetch_u64.cpp
  SYCL :: lsc/lsc_surf_prefetch_u8u32.cpp
  SYCL :: lsc/lsc_surf_store_u16u32.cpp
  SYCL :: lsc/lsc_surf_store_u32.cpp
  SYCL :: lsc/lsc_surf_store_u32_stateless.cpp
  SYCL :: lsc/lsc_surf_store_u64.cpp
  SYCL :: lsc/lsc_surf_store_u64_stateless.cpp
  SYCL :: lsc/lsc_surf_store_u8_u16.cpp
  SYCL :: lsc/lsc_surf_store_u8u32.cpp
  SYCL :: lsc/lsc_usm_block_load_u32.cpp
  SYCL :: lsc/lsc_usm_block_load_u32_64.cpp
  SYCL :: lsc/lsc_usm_block_load_u32_scalar_off.cpp
  SYCL :: lsc/lsc_usm_block_load_u64.cpp
  SYCL :: lsc/lsc_usm_block_load_u64_64.cpp
  SYCL :: lsc/lsc_usm_block_load_u64_scalar_off.cpp

@bader bader merged commit c39de71 into intel:sycl Mar 21, 2023
@@ -23,7 +23,7 @@ else()
set(LIBIGFXCMRT_EMU ${LLVM_BINARY_DIR}/pi_esimd_emulator_deps/lib/libigfxcmrt_emu${CMAKE_SHARED_LIBRARY_SUFFIX})
endif()

set (DEFAULT_CM_EMU_PREBUILT_PACKAGE "https://github.com/intel/cm-cpu-emulation/releases/download/v2022-07-06/intel-cmemu-1.0.23.u20.04-release.x86_64.tar.xz")
set (DEFAULT_CM_EMU_PREBUILT_PACKAGE "https://github.com/intel/cm-cpu-emulation/releases/download/1.0.23/intel-cmemu-1.0.23.u20.04-release.x86_64.tar.xz")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a newer version of cm emu (Feb 2023): 1.0.31.
We need to try using it instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was also pointed out by @bader, that it is better to download during cmake run, not when compiling.

@turinevgeny turinevgeny deleted the UpdateCMEmuPackagePath branch March 28, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants