[SYCL-MLIR]: Argument Promotion Transformation (part 2)

[etiotto]

Enhance ArgumentPromotion to allow processing calls with only some peelable arguments.
Example:

    func.func private @foo(%arg0: memref<?x!llvm.struct<(i32)>>, %arg1: memref<?x!llvm.struct<(f32)>>) {
      %c0 = arith.constant 0 : index
      %0 = "polygeist.subindex"(%arg0, %c0) : (memref<?x!llvm.struct<(i32)>>, index) -> memref<?xi32>
      %1 = sycl.addrspacecast %arg1 : memref<?x!llvm.struct<(f32)>> to memref<?x!llvm.struct<(f32)>, 4>
      ... 

Only %arg0 can be peeled because %arg1 is not used by a subindex instruction.

[etiotto]

Depends on #8679

[victor-eds]

Can we have the tests mentioned here? I'm not asking for all of them to produce the expected outcome, but at least having them there with a comment in case they don't to have in mind there's room for improvement

[etiotto]

Can we have the tests mentioned here? I'm not asking for all of them to produce the expected outcome, but at least having them there with a comment in case they don't to have in mind there's room for improvement

I have added them. I have:

 // COM:      Test that a peelable argument can be peeled when another argument with the expected type 
 // COM-NEXT: cannot be peeled (because used in the callee by an invalid instruction).
 gpu.func @test5() kernel {

 // COM: Test that an argument that is a multidimentionsal memref is not peeled.
 gpu.func @test6() kernel {
 
  // COM: Test that an argument that is a memref with non-id layouit is not peeled.
 gpu.func @test7() kernel {

 // COM: Test that an argument that is a memref with element type 'struct<(struct<(...)>)>' is not peeled.
 gpu.func @test8() kernel {