Skip to content

[SYCL][ESIMD] Add support for addc and subb operations #8758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 30, 2023
Merged

[SYCL][ESIMD] Add support for addc and subb operations #8758

merged 9 commits into from
Mar 30, 2023

Conversation

fineg74
Copy link
Contributor

@fineg74 fineg74 commented Mar 23, 2023

No description provided.

@fineg74 fineg74 requested a review from a team as a code owner March 23, 2023 19:58
@fineg74 fineg74 mentioned this pull request Mar 23, 2023
Closed
@fineg74
Copy link
Contributor Author

fineg74 commented Mar 23, 2023

Complementary test PR: intel/llvm-test-suite#1690

@fineg74 fineg74 temporarily deployed to aws March 23, 2023 21:15 — with GitHub Actions Inactive
@fineg74 fineg74 temporarily deployed to aws March 23, 2023 23:08 — with GitHub Actions Inactive
@fineg74
Copy link
Contributor Author

fineg74 commented Mar 24, 2023

AMDGPU failure :
Basic/kernel_info.cpp is not related to the change

@fineg74
Copy link
Contributor Author

fineg74 commented Mar 24, 2023

CUDA failure :
Basic/kernel_info.cpp is not related to the change

sarnex
sarnex reviewed Mar 24, 2023
View reviewed changes
@fineg74 fineg74 temporarily deployed to aws March 24, 2023 15:45 — with GitHub Actions Inactive
@fineg74
Merge remote-tracking branch 'origin/sycl' into addc
fe01d7c 
# Conflicts:
#	llvm/lib/SYCLLowerIR/ESIMD/LowerESIMD.cpp
#	sycl/include/sycl/ext/intel/experimental/esimd/detail/math_intrin.hpp
@fineg74 fineg74 temporarily deployed to aws March 24, 2023 18:20 — with GitHub Actions Inactive
@fineg74 fineg74 temporarily deployed to aws March 24, 2023 19:24 — with GitHub Actions Inactive
@fineg74 fineg74 temporarily deployed to aws March 25, 2023 06:32 — with GitHub Actions Inactive
@fineg74 fineg74 temporarily deployed to aws March 25, 2023 07:04 — with GitHub Actions Inactive
sarnex
sarnex approved these changes Mar 27, 2023
View reviewed changes
v-klochkov
v-klochkov requested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, for late response, I needed to do a bit of research to see if we have better options than using GenX intrinsics.

@fineg74 fineg74 temporarily deployed to aws March 29, 2023 06:55 — with GitHub Actions Inactive
@fineg74 fineg74 temporarily deployed to aws March 29, 2023 10:06 — with GitHub Actions Inactive
@fineg74
Copy link
Contributor Author

fineg74 commented Mar 29, 2023

Test failures:
SYCL :: AtomicRef/atomic_memory_order_acq_rel.cpp
GroupAlgorithm/reduce_sycl2020.cpp
are not related to the change

@v-klochkov
Copy link
Contributor

@sarnex - you asked some questions, it is unclear if they are answered. Please mark as 'Resolved' those that got some additional fix or answer from Gregory.

@sarnex
Copy link
Contributor

sarnex commented Mar 30, 2023

@v-klochkov everything is addressed, i marked them as resolved, thanks gregory!

@v-klochkov v-klochkov merged commit 0a09893 into intel:sycl Mar 30, 2023
@fineg74 fineg74 deleted the addc branch March 30, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnex sarnex sarnex approved these changes

@vmustya vmustya vmustya left review comments

@v-klochkov v-klochkov v-klochkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fineg74 @v-klochkov @sarnex @vmustya