-
Notifications
You must be signed in to change notification settings - Fork 788
[SYCL][FPGA] Implement kernel attribute max_work_group_size #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGindinson
reviewed
Nov 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the test file names have an intel_
prefix?
romanovvlad
reviewed
Nov 28, 2019
#896 needs to be committed first |
42a332d
to
5305e99
Compare
5305e99
to
d931620
Compare
d931620
to
0b3cf6a
Compare
AGindinson
reviewed
Dec 4, 2019
mlychkov
previously approved these changes
Dec 5, 2019
AGindinson
previously approved these changes
Dec 5, 2019
@MrSidims, please, resolve the merge conflicts. |
Applies to a device function/lambda function. Indicates the maximum dimensions of a work group. Values must be positive integers. This is similar to reqd_work_group_size, but allows work groups that are smaller or equal to the specified sizes. Signed-off-by: Dmitry Sidorov <[email protected]>
0a92ab0
to
29c2268
Compare
@bader done |
AGindinson
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to a device function/lambda function. Indicates the
maximum dimensions of a work group. Values must be positive
integers. This is similar to reqd_work_group_size, but allows
work groups that are smaller or equal to the specified sizes.
Signed-off-by: Dmitry Sidorov [email protected]