Skip to content

[SYCL][FPGA] Implement kernel attribute max_work_group_size #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

MrSidims
Copy link
Contributor

Applies to a device function/lambda function. Indicates the
maximum dimensions of a work group. Values must be positive
integers. This is similar to reqd_work_group_size, but allows
work groups that are smaller or equal to the specified sizes.

Signed-off-by: Dmitry Sidorov [email protected]

Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the test file names have an intel_ prefix?

@MrSidims
Copy link
Contributor Author

MrSidims commented Dec 1, 2019

#896 needs to be committed first

@MrSidims MrSidims force-pushed the private/MrSidims/MaxWGSNEW branch from 42a332d to 5305e99 Compare December 1, 2019 13:34
@MrSidims MrSidims force-pushed the private/MrSidims/MaxWGSNEW branch from 5305e99 to d931620 Compare December 3, 2019 16:27
@MrSidims MrSidims requested a review from AGindinson December 3, 2019 16:30
@MrSidims MrSidims force-pushed the private/MrSidims/MaxWGSNEW branch from d931620 to 0b3cf6a Compare December 4, 2019 11:20
@MrSidims MrSidims requested a review from mlychkov December 5, 2019 11:06
mlychkov
mlychkov previously approved these changes Dec 5, 2019
AGindinson
AGindinson previously approved these changes Dec 5, 2019
@bader
Copy link
Contributor

bader commented Dec 5, 2019

@MrSidims, please, resolve the merge conflicts.

Applies to a device function/lambda function. Indicates the
maximum dimensions of a work group. Values must be positive
integers. This is similar to reqd_work_group_size, but allows
work groups that are smaller or equal to the specified sizes.

Signed-off-by: Dmitry Sidorov <[email protected]>
@MrSidims MrSidims dismissed stale reviews from AGindinson and mlychkov via 29c2268 December 5, 2019 16:26
@MrSidims MrSidims force-pushed the private/MrSidims/MaxWGSNEW branch from 0a92ab0 to 29c2268 Compare December 5, 2019 16:26
@MrSidims
Copy link
Contributor Author

MrSidims commented Dec 5, 2019

@bader done

@bader bader requested a review from AGindinson December 5, 2019 16:34
@bader bader merged commit 9053642 into intel:sycl Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants