[SYCL] Fix PI event leak in memcpy2d device-host fallback #8878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fallback mechanism for memcpy2d and copy2d between host and device enqueues a number of memcpy operations to/from device and inserts a marker event to signify the convergence. Currently the intermediate events are not correctly released, causing them to leak. This commit fixes this by utilizing an existing RAII PI event managed object to manage the lifetime of these events. Signed-off-by: Larsen, Steffen <[email protected]>
| @@ -963,13 +964,19 @@ void MemoryManager::copy_2d_usm(const void *SrcMem, size_t SrcPitch, | |||
| #endif // NDEBUG | |||
|
|
|||
| // The fallback in this case is to insert a copy per row. | |||
| // We keep both a vector of the raw PI events and managed objects to ensure | |||
There was a problem hiding this comment.
nit, but I'd change to
// The fallback in this case is to insert a copy per row.
std::vector<OwnedPiEvent> CopyEventsManaged;
CopyEventsManaged.reserve(Height);
// We'll need continuous range of events for a wait later as well.
std::vector<RT::PiEvent> CopyEvents(Height);
aelovikov-intel
approved these changes
Mar 30, 2023
Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback mechanism for memcpy2d and copy2d between host and device enqueues a number of memcpy operations to/from device and inserts a marker event to signify the convergence. Currently the intermediate events are not correctly released, causing them to leak. This commit fixes this by utilizing an existing RAII PI event managed object to manage the lifetime of these events.